milvus icon indicating copy to clipboard operation
milvus copied to clipboard

fix: Avoid datarace in clustering compaction

Open wayblink opened this issue 1 year ago • 3 comments

#34289

wayblink avatar Jul 01 '24 06:07 wayblink

@wayblink Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

mergify[bot] avatar Jul 01 '24 06:07 mergify[bot]

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jul 01 '24 06:07 mergify[bot]

rerun ut

wayblink avatar Jul 02 '24 03:07 wayblink

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jul 02 '24 11:07 mergify[bot]

/run-cpu-e2e

wayblink avatar Jul 02 '24 12:07 wayblink

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jul 02 '24 13:07 mergify[bot]

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.51%. Comparing base (fa8d641) to head (15c5b8e). Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34288      +/-   ##
==========================================
- Coverage   80.53%   80.51%   -0.02%     
==========================================
  Files        1095     1095              
  Lines      137835   137839       +4     
==========================================
- Hits       111003   110986      -17     
- Misses      22683    22702      +19     
- Partials     4149     4151       +2     
Files Coverage Δ
internal/datacoord/compaction_task.go 66.66% <100.00%> (+9.52%) :arrow_up:
internal/datacoord/compaction_task_clustering.go 25.88% <50.00%> (-0.14%) :arrow_down:

... and 26 files with indirect coverage changes

codecov[bot] avatar Jul 02 '24 16:07 codecov[bot]

/approve /lgtm

czs007 avatar Jul 03 '24 09:07 czs007

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, wayblink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Jul 03 '24 09:07 sre-ci-robot