milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: Pre-allocate ids for compaction

Open bigsheeper opened this issue 1 year ago • 6 comments

This PR removes the dependency of compaction on the ID allocator by pre-allocating the logID and segmentID.

issue: https://github.com/milvus-io/milvus/issues/33957

bigsheeper avatar Jun 26 '24 06:06 bigsheeper

Codecov Report

Attention: Patch coverage is 81.81818% with 12 lines in your changes missing coverage. Please review.

Project coverage is 71.46%. Comparing base (3306bc2) to head (084284b). Report is 2 commits behind head on master.

:exclamation: Current head 084284b differs from pull request most recent head 73f13eb

Please upload reports for the commit 73f13eb to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34187      +/-   ##
==========================================
- Coverage   80.76%   71.46%   -9.30%     
==========================================
  Files        1161     1118      -43     
  Lines      141015   138971    -2044     
==========================================
- Hits       113892    99321   -14571     
- Misses      22750    35377   +12627     
+ Partials     4373     4273     -100     
Files Coverage Δ
internal/datacoord/compaction.go 71.55% <100.00%> (+0.95%) :arrow_up:
internal/datacoord/compaction_task_clustering.go 48.49% <100.00%> (-6.85%) :arrow_down:
internal/datacoord/compaction_task_l0.go 65.30% <100.00%> (-2.86%) :arrow_down:
internal/datacoord/compaction_task_mix.go 70.53% <100.00%> (+8.75%) :arrow_up:
internal/datacoord/compaction_trigger.go 86.53% <100.00%> (-0.47%) :arrow_down:
internal/datacoord/import_util.go 90.75% <100.00%> (+0.05%) :arrow_up:
internal/datanode/compaction/compactor_common.go 88.88% <100.00%> (ø)
internal/datanode/compaction/l0_compactor.go 91.60% <100.00%> (+0.03%) :arrow_up:
internal/datanode/importv2/task_import.go 86.61% <100.00%> (ø)
internal/datanode/importv2/task_l0_import.go 78.86% <100.00%> (ø)
... and 4 more

... and 370 files with indirect coverage changes

codecov[bot] avatar Jun 26 '24 09:06 codecov[bot]

rerun ut

bigsheeper avatar Jun 27 '24 04:06 bigsheeper

/hold also need to pre-allocate segmentID for mix compaction

bigsheeper avatar Jun 27 '24 08:06 bigsheeper

/unhold

bigsheeper avatar Jun 28 '24 09:06 bigsheeper

rerun ut

bigsheeper avatar Jul 01 '24 02:07 bigsheeper

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jul 03 '24 10:07 mergify[bot]

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jul 04 '24 02:07 mergify[bot]

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jul 04 '24 02:07 mergify[bot]

rerun ut

bigsheeper avatar Jul 08 '24 06:07 bigsheeper

/lgtm

wayblink avatar Jul 08 '24 10:07 wayblink

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jul 13 '24 03:07 mergify[bot]

/approve /lgtm

czs007 avatar Jul 16 '24 08:07 czs007

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Jul 16 '24 08:07 sre-ci-robot

rerun ut

bigsheeper avatar Jul 16 '24 13:07 bigsheeper

/lgtm

czs007 avatar Jul 17 '24 03:07 czs007