milvus
milvus copied to clipboard
enhance: Pre-allocate ids for compaction
This PR removes the dependency of compaction on the ID allocator by pre-allocating the logID and segmentID.
issue: https://github.com/milvus-io/milvus/issues/33957
Codecov Report
Attention: Patch coverage is 81.81818% with 12 lines in your changes missing coverage. Please review.
Project coverage is 71.46%. Comparing base (
3306bc2) to head (084284b). Report is 2 commits behind head on master.
:exclamation: Current head 084284b differs from pull request most recent head 73f13eb
Please upload reports for the commit 73f13eb to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## master #34187 +/- ##
==========================================
- Coverage 80.76% 71.46% -9.30%
==========================================
Files 1161 1118 -43
Lines 141015 138971 -2044
==========================================
- Hits 113892 99321 -14571
- Misses 22750 35377 +12627
+ Partials 4373 4273 -100
| Files | Coverage Δ | |
|---|---|---|
| internal/datacoord/compaction.go | 71.55% <100.00%> (+0.95%) |
:arrow_up: |
| internal/datacoord/compaction_task_clustering.go | 48.49% <100.00%> (-6.85%) |
:arrow_down: |
| internal/datacoord/compaction_task_l0.go | 65.30% <100.00%> (-2.86%) |
:arrow_down: |
| internal/datacoord/compaction_task_mix.go | 70.53% <100.00%> (+8.75%) |
:arrow_up: |
| internal/datacoord/compaction_trigger.go | 86.53% <100.00%> (-0.47%) |
:arrow_down: |
| internal/datacoord/import_util.go | 90.75% <100.00%> (+0.05%) |
:arrow_up: |
| internal/datanode/compaction/compactor_common.go | 88.88% <100.00%> (ø) |
|
| internal/datanode/compaction/l0_compactor.go | 91.60% <100.00%> (+0.03%) |
:arrow_up: |
| internal/datanode/importv2/task_import.go | 86.61% <100.00%> (ø) |
|
| internal/datanode/importv2/task_l0_import.go | 78.86% <100.00%> (ø) |
|
| ... and 4 more |
rerun ut
/hold also need to pre-allocate segmentID for mix compaction
/unhold
rerun ut
@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
rerun ut
/lgtm
@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bigsheeper, czs007
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~internal/datacoord/OWNERS~~ [czs007]
- ~~internal/datanode/OWNERS~~ [czs007]
- ~~internal/proto/OWNERS~~ [czs007]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
rerun ut
/lgtm