milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: [cherry-pick]Unset properties when value is empty

Open xige-16 opened this issue 1 year ago • 4 comments

issue: https://github.com/milvus-io/milvus/issues/34151 pr: #34154 /kind enhancement

xige-16 avatar Jun 25 '24 08:06 xige-16

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xige-16 To complete the pull request process, please assign congqixia after the PR has been reviewed. You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Jun 25 '24 08:06 sre-ci-robot

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Jun 25 '24 09:06 mergify[bot]

/run-cpu-e2e

xige-16 avatar Jun 25 '24 09:06 xige-16

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.08%. Comparing base (bff0bd7) to head (e6801f1). Report is 32 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #34155      +/-   ##
==========================================
+ Coverage   83.07%   83.08%   +0.01%     
==========================================
  Files         851      851              
  Lines      107089   107093       +4     
==========================================
+ Hits        88961    88982      +21     
+ Misses      14814    14793      -21     
- Partials     3314     3318       +4     
Files Coverage Δ
internal/rootcoord/alter_collection_task.go 100.00% <100.00%> (ø)

... and 23 files with indirect coverage changes

codecov[bot] avatar Jun 26 '24 04:06 codecov[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale[bot] avatar Jul 28 '24 13:07 stale[bot]