milvus
milvus copied to clipboard
enhance: implement wal managerment on streaming node
issue: #33285
- add lifetime control for wal.
- implement distributed-safe wal manager on streaming node.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: chyezh
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Codecov Report
Attention: Patch coverage is 87.27273% with 35 lines in your changes missing coverage. Please review.
Project coverage is 84.30%. Comparing base (
7611128) to head (fcfdc6b). Report is 4 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #34153 +/- ##
==========================================
+ Coverage 80.92% 84.30% +3.37%
==========================================
Files 1113 850 -263
Lines 138345 114624 -23721
==========================================
- Hits 111960 96629 -15331
+ Misses 22145 13749 -8396
- Partials 4240 4246 +6
| Files | Coverage Δ | |
|---|---|---|
| ...ernal/streamingnode/server/walmanager/wal_state.go | 100.00% <100.00%> (ø) |
|
| .../streamingnode/server/walmanager/wal_state_pair.go | 100.00% <100.00%> (ø) |
|
| pkg/streaming/walimpls/impls/rmq/builder.go | 35.71% <ø> (ø) |
|
| ...streamingnode/server/wal/utility/reorder_buffer.go | 87.50% <60.00%> (-12.50%) |
:arrow_down: |
| ...treamingnode/server/wal/adaptor/scanner_adaptor.go | 85.00% <25.00%> (-9.45%) |
:arrow_down: |
| ...al/streamingnode/server/walmanager/wal_lifetime.go | 89.55% <89.55%> (ø) |
|
| ...al/streamingnode/server/walmanager/manager_impl.go | 87.14% <87.14%> (ø) |
|
| internal/util/streamingutil/util/wal_selector.go | 60.71% <60.71%> (ø) |
fix unresolved issues in the next PR.
/lgtm