milvus icon indicating copy to clipboard operation
milvus copied to clipboard

feature: support truncate collection

Open PowderLi opened this issue 1 year ago • 9 comments

#26280

PowderLi avatar May 11 '24 16:05 PowderLi

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PowderLi To complete the pull request process, please assign yanliang567 after the PR has been reviewed. You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 11 '24 16:05 sre-ci-robot

@PowderLi

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

mergify[bot] avatar May 11 '24 16:05 mergify[bot]

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 11 '24 17:05 mergify[bot]

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 11 '24 17:05 mergify[bot]

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 13 '24 10:05 mergify[bot]

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 13 '24 10:05 mergify[bot]

Codecov Report

Attention: Patch coverage is 95.78686% with 34 lines in your changes missing coverage. Please review.

Project coverage is 82.31%. Comparing base (60baaed) to head (71676fe). Report is 4 commits behind head on master.

:exclamation: Current head 71676fe differs from pull request most recent head 2b0d793

Please upload reports for the commit 2b0d793 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32994      +/-   ##
==========================================
+ Coverage   81.23%   82.31%   +1.08%     
==========================================
  Files        1029     1012      -17     
  Lines      132215   129688    -2527     
==========================================
- Hits       107399   106747     -652     
+ Misses      20766    18930    -1836     
+ Partials     4050     4011      -39     
Files Coverage Δ
internal/datacoord/index_meta.go 98.32% <100.00%> (+3.23%) :arrow_up:
internal/datacoord/index_service.go 95.83% <100.00%> (+0.91%) :arrow_up:
internal/distributed/datacoord/client/client.go 98.00% <100.00%> (+0.04%) :arrow_up:
internal/distributed/datacoord/service.go 89.03% <100.00%> (+0.19%) :arrow_up:
internal/distributed/rootcoord/client/client.go 93.81% <100.00%> (-1.84%) :arrow_down:
internal/distributed/rootcoord/service.go 81.88% <100.00%> (-0.65%) :arrow_down:
internal/metastore/catalog.go 100.00% <ø> (ø)
internal/proxy/impl.go 86.58% <100.00%> (+0.33%) :arrow_up:
internal/proxy/task.go 88.05% <100.00%> (+0.31%) :arrow_up:
internal/rootcoord/alter_alias_task.go 100.00% <100.00%> (ø)
... and 15 more

... and 252 files with indirect coverage changes

codecov[bot] avatar May 13 '24 12:05 codecov[bot]

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 13 '24 17:05 mergify[bot]

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 20 '24 15:05 mergify[bot]

/reopen

PowderLi avatar Jun 28 '24 10:06 PowderLi

@PowderLi: Failed to re-open PR: state cannot be changed. The master-truncate-collection branch was force-pushed or recreated.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sre-ci-robot avatar Jun 28 '24 10:06 sre-ci-robot