milvus
milvus copied to clipboard
enhance: add the cost response for the rest api
issue: https://github.com/milvus-io/milvus/issues/30436
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: SimFG
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
Codecov Report
Attention: Patch coverage is 80.00000% with 12 lines in your changes are missing coverage. Please review.
Project coverage is 81.80%. Comparing base (
4de063a) to head (8c94e26). Report is 17 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #32620 +/- ##
==========================================
+ Coverage 81.73% 81.80% +0.06%
==========================================
Files 1002 1005 +3
Lines 125438 126607 +1169
==========================================
+ Hits 102532 103568 +1036
- Misses 18999 19114 +115
- Partials 3907 3925 +18
| Files | Coverage Δ | |
|---|---|---|
| ...nternal/distributed/proxy/httpserver/request_v2.go | 100.00% <100.00%> (ø) |
|
| internal/proxy/util.go | 90.74% <100.00%> (+0.06%) |
:arrow_up: |
| ...nternal/distributed/proxy/httpserver/handler_v2.go | 89.14% <76.47%> (-0.27%) |
:arrow_down: |
I wonder that there is no need to update restful v1 only restful v2 is required
whether return cost or not, should we add a switch to control ?
@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
whether return cost or not, should we add a switch to control ?
I think it is unnecessary, because there is no switch to control the return result of rpc, and this part is not functional. If the return value is controlled by the switch, I think it is a bit strange, and there will be inconsistencies in the functions between the cloud and offline, and there will be compatibility issues.
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: czs007, SimFG
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~internal/distributed/OWNERS~~ [czs007]
- ~~internal/proxy/OWNERS~~ [czs007]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment