milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: Support dynamic config for opentelemetry trace

Open aoiasd opened this issue 1 year ago • 16 comments

relate: https://github.com/milvus-io/milvus/issues/31940

aoiasd avatar Apr 11 '24 09:04 aoiasd

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 11 '24 09:04 mergify[bot]

Codecov Report

Attention: Patch coverage is 89.83051% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 81.83%. Comparing base (83ce352) to head (e9998d6). Report is 40 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32169      +/-   ##
==========================================
+ Coverage   81.77%   81.83%   +0.05%     
==========================================
  Files        1001      993       -8     
  Lines      125359   125727     +368     
==========================================
+ Hits       102517   102883     +366     
  Misses      18956    18956              
- Partials     3886     3888       +2     
Files Coverage Δ
internal/util/initcore/init_core.go 90.09% <100.00%> (+1.86%) :arrow_up:
pkg/util/paramtable/component_param.go 98.44% <100.00%> (+<0.01%) :arrow_up:
pkg/tracer/tracer.go 79.62% <97.22%> (+79.62%) :arrow_up:
internal/core/src/common/init_c.cpp 0.00% <0.00%> (ø)

... and 223 files with indirect coverage changes

codecov[bot] avatar Apr 11 '24 12:04 codecov[bot]

@aoiasd ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 16 '24 08:04 mergify[bot]

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 16 '24 10:04 mergify[bot]

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 17 '24 03:04 mergify[bot]

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 18 '24 08:04 mergify[bot]

/run-cpu-e2e

aoiasd avatar Apr 19 '24 02:04 aoiasd

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 24 '24 09:04 mergify[bot]

@aoiasd ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 26 '24 07:04 mergify[bot]

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 28 '24 08:04 mergify[bot]

/run-cpu-e2e

aoiasd avatar Apr 28 '24 10:04 aoiasd

rerun ut

aoiasd avatar Apr 28 '24 10:04 aoiasd

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 07 '24 02:05 mergify[bot]

@aoiasd ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 07 '24 02:05 mergify[bot]

@aoiasd Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

mergify[bot] avatar May 07 '24 07:05 mergify[bot]

/lgtm for c++ part

cydrain avatar May 09 '24 09:05 cydrain

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 09 '24 09:05 sre-ci-robot