milvus
milvus copied to clipboard
feat: datacoord/node watch based on rpc
issue: https://github.com/milvus-io/milvus/issues/25309
@yiwangdr E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@yiwangdr E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: xiaofan-luan, yiwangdr
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [xiaofan-luan]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@yiwangdr let's merge this ASAP and let the QA team test on it.
New changes are detected. LGTM label has been removed.
@yiwangdr E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@yiwangdr E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
@yiwangdr E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@yanliang567 the e2e test seems to be really unstable these days and we get many random failings
we have had a few server running for ci/e2e exclusively, please retry if it fails for env. issues.
/run-cpu-e2e
@yiwangdr E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@yiwangdr E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@yiwangdr E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@yiwangdr E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
rerun ut
/run-cpu-e2e
rerun ut
Codecov Report
Attention: Patch coverage is 82.39437% with 200 lines in your changes are missing coverage. Please review.
Project coverage is 81.79%. Comparing base (
ac82cef) to head (92963bb). Report is 31 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #32036 +/- ##
==========================================
+ Coverage 81.76% 81.79% +0.03%
==========================================
Files 998 1000 +2
Lines 124270 125153 +883
==========================================
+ Hits 101607 102369 +762
- Misses 18798 18883 +85
- Partials 3865 3901 +36
| Files | Coverage Δ | |
|---|---|---|
| internal/datacoord/channel_manager_factory.go | 100.00% <100.00%> (ø) |
|
| internal/datacoord/session.go | 84.61% <ø> (ø) |
|
| internal/datanode/data_node.go | 82.20% <100.00%> (+0.78%) |
:arrow_up: |
| internal/datanode/event_manager.go | 80.16% <100.00%> (-2.48%) |
:arrow_down: |
| internal/distributed/datanode/service.go | 82.92% <100.00%> (ø) |
|
| pkg/util/conc/pool.go | 88.13% <100.00%> (-0.20%) |
:arrow_down: |
| pkg/util/paramtable/component_param.go | 98.44% <100.00%> (+<0.01%) |
:arrow_up: |
| tests/integration/minicluster_v2.go | 72.72% <100.00%> (+0.20%) |
:arrow_up: |
| internal/datacoord/services.go | 85.57% <50.00%> (+0.02%) |
:arrow_up: |
| internal/distributed/datacoord/service.go | 88.83% <50.00%> (ø) |
|
| ... and 10 more |
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: xiaofan-luan, XuanYang-cn, yiwangdr
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [xiaofan-luan]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment