milvus icon indicating copy to clipboard operation
milvus copied to clipboard

feat: datacoord/node watch based on rpc

Open yiwangdr opened this issue 1 year ago • 21 comments

issue: https://github.com/milvus-io/milvus/issues/25309

yiwangdr avatar Apr 09 '24 02:04 yiwangdr

@yiwangdr E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 10 '24 19:04 mergify[bot]

@yiwangdr E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 15 '24 22:04 mergify[bot]

/lgtm /approve

xiaofan-luan avatar Apr 19 '24 01:04 xiaofan-luan

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan, yiwangdr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Apr 19 '24 01:04 sre-ci-robot

@yiwangdr let's merge this ASAP and let the QA team test on it.

xiaofan-luan avatar Apr 22 '24 01:04 xiaofan-luan

New changes are detected. LGTM label has been removed.

sre-ci-robot avatar Apr 23 '24 20:04 sre-ci-robot

@yiwangdr E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 23 '24 20:04 mergify[bot]

@yiwangdr E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 24 '24 03:04 mergify[bot]

/run-cpu-e2e

yiwangdr avatar Apr 24 '24 07:04 yiwangdr

@yiwangdr E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 24 '24 07:04 mergify[bot]

@yanliang567 the e2e test seems to be really unstable these days and we get many random failings

xiaofan-luan avatar Apr 24 '24 08:04 xiaofan-luan

we have had a few server running for ci/e2e exclusively, please retry if it fails for env. issues.

yanliang567 avatar Apr 25 '24 00:04 yanliang567

/run-cpu-e2e

yanliang567 avatar Apr 25 '24 00:04 yanliang567

@yiwangdr E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 25 '24 01:04 mergify[bot]

@yiwangdr E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 25 '24 04:04 mergify[bot]

@yiwangdr E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 25 '24 23:04 mergify[bot]

@yiwangdr E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 29 '24 02:04 mergify[bot]

rerun ut

yiwangdr avatar Apr 29 '24 14:04 yiwangdr

/run-cpu-e2e

yiwangdr avatar Apr 29 '24 16:04 yiwangdr

rerun ut

yiwangdr avatar Apr 29 '24 21:04 yiwangdr

Codecov Report

Attention: Patch coverage is 82.39437% with 200 lines in your changes are missing coverage. Please review.

Project coverage is 81.79%. Comparing base (ac82cef) to head (92963bb). Report is 31 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32036      +/-   ##
==========================================
+ Coverage   81.76%   81.79%   +0.03%     
==========================================
  Files         998     1000       +2     
  Lines      124270   125153     +883     
==========================================
+ Hits       101607   102369     +762     
- Misses      18798    18883      +85     
- Partials     3865     3901      +36     
Files Coverage Δ
internal/datacoord/channel_manager_factory.go 100.00% <100.00%> (ø)
internal/datacoord/session.go 84.61% <ø> (ø)
internal/datanode/data_node.go 82.20% <100.00%> (+0.78%) :arrow_up:
internal/datanode/event_manager.go 80.16% <100.00%> (-2.48%) :arrow_down:
internal/distributed/datanode/service.go 82.92% <100.00%> (ø)
pkg/util/conc/pool.go 88.13% <100.00%> (-0.20%) :arrow_down:
pkg/util/paramtable/component_param.go 98.44% <100.00%> (+<0.01%) :arrow_up:
tests/integration/minicluster_v2.go 72.72% <100.00%> (+0.20%) :arrow_up:
internal/datacoord/services.go 85.57% <50.00%> (+0.02%) :arrow_up:
internal/distributed/datacoord/service.go 88.83% <50.00%> (ø)
... and 10 more

... and 40 files with indirect coverage changes

codecov[bot] avatar Apr 29 '24 23:04 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan, XuanYang-cn, yiwangdr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 07 '24 07:05 sre-ci-robot