milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: enable compaction dynamicly

Open XuanYang-cn opened this issue 1 year ago • 40 comments

Make EnableCompaction able to change dynamicly

See also: #31059

XuanYang-cn avatar Mar 06 '24 08:03 XuanYang-cn

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: XuanYang-cn To complete the pull request process, please assign yanliang567 after the PR has been reviewed. You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Mar 06 '24 11:03 sre-ci-robot

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Mar 06 '24 12:03 mergify[bot]

/run-cpu-e2e

XuanYang-cn avatar Mar 06 '24 12:03 XuanYang-cn

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Mar 06 '24 12:03 mergify[bot]

Codecov Report

Attention: Patch coverage is 85.58140% with 31 lines in your changes missing coverage. Please review.

Project coverage is 82.20%. Comparing base (3d29907) to head (071082c). Report is 232 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #31068      +/-   ##
==========================================
- Coverage   82.21%   82.20%   -0.01%     
==========================================
  Files        1012     1003       -9     
  Lines      129202   129446     +244     
==========================================
+ Hits       106223   106413     +190     
- Misses      19001    19055      +54     
  Partials     3978     3978              
Files Coverage Δ
internal/datacoord/compaction_trigger_v2.go 90.24% <100.00%> (ø)
internal/datacoord/compaction_view_manager.go 97.01% <100.00%> (ø)
internal/datacoord/index_service.go 94.88% <ø> (-0.01%) :arrow_down:
internal/datacoord/meta.go 93.45% <100.00%> (-0.84%) :arrow_down:
internal/datacoord/server.go 72.03% <100.00%> (+0.02%) :arrow_up:
pkg/util/paramtable/component_param.go 98.50% <ø> (ø)
internal/datacoord/services.go 85.93% <25.00%> (+0.21%) :arrow_up:
internal/datacoord/compaction.go 89.90% <82.05%> (+1.28%) :arrow_up:
internal/datacoord/compaction_trigger.go 87.68% <84.78%> (+0.22%) :arrow_up:

... and 219 files with indirect coverage changes

codecov[bot] avatar Mar 06 '24 13:03 codecov[bot]

install failed /run-cpu-e2e

XuanYang-cn avatar Mar 07 '24 09:03 XuanYang-cn

/run-cpu-e2e

XuanYang-cn avatar Mar 07 '24 12:03 XuanYang-cn

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Mar 13 '24 08:03 mergify[bot]

install failed /run-cpu-e2e

XuanYang-cn avatar Mar 13 '24 08:03 XuanYang-cn

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Mar 25 '24 07:03 mergify[bot]

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Mar 26 '24 07:03 mergify[bot]

/run-cpu-e2e build failed

XuanYang-cn avatar Mar 26 '24 07:03 XuanYang-cn

rerun ut

XuanYang-cn avatar Mar 26 '24 07:03 XuanYang-cn

/run-cpu-e2e

XuanYang-cn avatar Mar 26 '24 07:03 XuanYang-cn

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Mar 26 '24 08:03 mergify[bot]

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Mar 28 '24 02:03 mergify[bot]

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Mar 28 '24 04:03 mergify[bot]

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 01 '24 08:04 mergify[bot]

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 01 '24 08:04 mergify[bot]

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 04 '24 08:04 mergify[bot]

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 09 '24 05:04 mergify[bot]

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 10 '24 06:04 mergify[bot]

/run-cpu-e2e

XuanYang-cn avatar Apr 10 '24 06:04 XuanYang-cn

/run-cpu-e2e

XuanYang-cn avatar Apr 10 '24 12:04 XuanYang-cn

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 10 '24 13:04 mergify[bot]

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 18 '24 11:04 mergify[bot]

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 23 '24 02:04 mergify[bot]

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 23 '24 02:04 mergify[bot]

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 23 '24 12:04 mergify[bot]

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 24 '24 04:04 mergify[bot]

/run-cpu-e2e

XuanYang-cn avatar Apr 24 '24 06:04 XuanYang-cn