milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: grpc support more compression

Open PowderLi opened this issue 1 year ago • 12 comments

issue: #29481 support deflate, lz4, snappy gzip supported by grpc/encoding zstd supported in former pr #21689

PowderLi avatar Feb 28 '24 10:02 PowderLi

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PowderLi To complete the pull request process, please assign congqixia after the PR has been reviewed. You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Feb 28 '24 10:02 sre-ci-robot

Codecov Report

Attention: Patch coverage is 73.88535% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 80.99%. Comparing base (5be3953) to head (41afb17). Report is 287 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #30904      +/-   ##
==========================================
+ Coverage   80.94%   80.99%   +0.05%     
==========================================
  Files         967      981      +14     
  Lines      139292   140060     +768     
==========================================
+ Hits       112747   113441     +694     
- Misses      22803    22840      +37     
- Partials     3742     3779      +37     
Files Coverage Δ
internal/util/grpcclient/client.go 87.72% <100.00%> (+1.07%) :arrow_up:
pkg/util/compressor/lz4/lz4.go 100.00% <100.00%> (ø)
pkg/util/paramtable/grpc_param.go 78.37% <100.00%> (+0.60%) :arrow_up:
pkg/util/compressor/deflate/zlib.go 87.50% <87.50%> (ø)
pkg/util/compressor/snappy/snappy.go 85.71% <85.71%> (ø)
pkg/util/compressor/zstd/zstd.go 68.96% <68.96%> (ø)
pkg/util/compressor/datadog/zstd.go 17.24% <17.24%> (ø)

... and 262 files with indirect coverage changes

codecov[bot] avatar Feb 28 '24 12:02 codecov[bot]

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Mar 22 '24 09:03 mergify[bot]

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Mar 22 '24 10:03 mergify[bot]

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Mar 22 '24 23:03 mergify[bot]

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Mar 22 '24 23:03 mergify[bot]

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Mar 27 '24 04:03 mergify[bot]

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Mar 27 '24 09:03 mergify[bot]

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Mar 27 '24 13:03 mergify[bot]

/run-cpu-e2e

PowderLi avatar Mar 28 '24 00:03 PowderLi

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Mar 28 '24 00:03 mergify[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale[bot] avatar May 04 '24 22:05 stale[bot]