milvus icon indicating copy to clipboard operation
milvus copied to clipboard

feat: add more operation detail info for better allocation

Open SimFG opened this issue 1 year ago • 14 comments

issue: #30436

SimFG avatar Feb 01 '24 07:02 SimFG

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Feb 01 '24 07:02 mergify[bot]

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Feb 01 '24 08:02 mergify[bot]

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Feb 01 '24 09:02 mergify[bot]

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Feb 19 '24 03:02 mergify[bot]

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Feb 19 '24 04:02 mergify[bot]

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Feb 19 '24 07:02 mergify[bot]

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Feb 19 '24 11:02 mergify[bot]

Codecov Report

Attention: Patch coverage is 84.13361% with 76 lines in your changes are missing coverage. Please review.

Project coverage is 81.07%. Comparing base (0c868b6) to head (5e1739a). Report is 27 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #30438      +/-   ##
==========================================
+ Coverage   80.95%   81.07%   +0.11%     
==========================================
  Files         977      969       -8     
  Lines      138781   139541     +760     
==========================================
+ Hits       112353   113126     +773     
+ Misses      22671    22651      -20     
- Partials     3757     3764       +7     
Files Coverage Δ
internal/core/src/common/QueryResult.h 97.05% <ø> (-1.48%) :arrow_down:
...al/core/src/query/visitors/ExecPlanNodeVisitor.cpp 97.41% <100.00%> (-1.29%) :arrow_down:
internal/core/src/segcore/Reduce.cpp 83.01% <100.00%> (-1.21%) :arrow_down:
internal/core/src/segcore/SegmentInterface.cpp 91.61% <100.00%> (-0.41%) :arrow_down:
internal/datacoord/index_builder.go 89.22% <100.00%> (ø)
internal/datacoord/server.go 72.83% <ø> (+0.35%) :arrow_up:
internal/datacoord/session_manager.go 85.36% <ø> (+2.13%) :arrow_up:
internal/proxy/channels_mgr.go 100.00% <ø> (ø)
internal/proxy/count_reducer.go 100.00% <100.00%> (ø)
internal/proxy/hook_interceptor.go 100.00% <100.00%> (+24.77%) :arrow_up:
... and 27 more

... and 232 files with indirect coverage changes

codecov[bot] avatar Feb 22 '24 14:02 codecov[bot]

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Feb 23 '24 08:02 mergify[bot]

/run-cpu-e2e

SimFG avatar Feb 23 '24 09:02 SimFG

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Feb 23 '24 09:02 mergify[bot]

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Feb 23 '24 10:02 mergify[bot]

/run-cpu-e2e

SimFG avatar Feb 23 '24 10:02 SimFG

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Feb 26 '24 15:02 mergify[bot]

/run-cpu-e2e

SimFG avatar Feb 27 '24 02:02 SimFG

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Feb 27 '24 04:02 mergify[bot]

/run-cpu-e2e

SimFG avatar Feb 27 '24 05:02 SimFG

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Feb 27 '24 07:02 mergify[bot]

rerun ut

SimFG avatar Feb 27 '24 08:02 SimFG

/run-cpu-e2e

SimFG avatar Feb 27 '24 08:02 SimFG

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Mar 14 '24 07:03 mergify[bot]

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Mar 15 '24 09:03 mergify[bot]

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Mar 18 '24 03:03 mergify[bot]

/run-cpu-e2e

SimFG avatar Mar 18 '24 04:03 SimFG

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Mar 19 '24 02:03 mergify[bot]

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Mar 19 '24 03:03 mergify[bot]

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Mar 19 '24 04:03 mergify[bot]

/lgtm /approve

xiaofan-luan avatar Mar 27 '24 22:03 xiaofan-luan

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Mar 27 '24 22:03 sre-ci-robot

I actaully give comment on the wrong issue, still work on reviewing of this PR

xiaofan-luan avatar Mar 27 '24 23:03 xiaofan-luan