milvus icon indicating copy to clipboard operation
milvus copied to clipboard

refine balance mechanism including:(#23454) (#23763)

Open MrPresent-Han opened this issue 2 years ago • 6 comments

  1. balance granuity to replica to avoid influence unrelated replicas
  2. avoid balance back and forth

MrPresent-Han avatar Apr 28 '23 03:04 MrPresent-Han

@MrPresent-Han Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

mergify[bot] avatar Apr 28 '23 03:04 mergify[bot]

@MrPresent-Han ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 28 '23 03:04 mergify[bot]

@MrPresent-Han ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 28 '23 04:04 mergify[bot]

Codecov Report

Merging #23791 (00bc7a6) into master (45fbe1d) will increase coverage by 0.01%. The diff coverage is 97.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23791      +/-   ##
==========================================
+ Coverage   82.08%   82.09%   +0.01%     
==========================================
  Files         744      744              
  Lines       97252    97343      +91     
==========================================
+ Hits        79826    79917      +91     
- Misses      14462    14464       +2     
+ Partials     2964     2962       -2     
Impacted Files Coverage Δ
internal/querycoordv2/balance/balance.go 90.62% <0.00%> (ø)
internal/querycoordv2/task/scheduler.go 80.04% <ø> (+1.81%) :arrow_up:
internal/datacoord/compaction.go 93.56% <100.00%> (ø)
internal/datacoord/meta.go 88.33% <100.00%> (+0.30%) :arrow_up:
internal/datacoord/server.go 71.80% <100.00%> (-0.15%) :arrow_down:
...al/querycoordv2/balance/rowcount_based_balancer.go 98.74% <100.00%> (-0.16%) :arrow_down:
...ernal/querycoordv2/balance/score_based_balancer.go 89.74% <100.00%> (+1.17%) :arrow_up:
internal/querycoordv2/balance/utils.go 76.92% <100.00%> (+6.63%) :arrow_up:
internal/querycoordv2/checkers/balance_checker.go 97.56% <100.00%> (+22.56%) :arrow_up:
internal/querycoordv2/checkers/controller.go 94.54% <100.00%> (ø)
... and 2 more

... and 18 files with indirect coverage changes

codecov[bot] avatar Apr 28 '23 04:04 codecov[bot]

@MrPresent-Han ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 28 '23 05:04 mergify[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, MrPresent-Han

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 04 '23 03:05 sre-ci-robot

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 04 '23 03:05 mergify[bot]

/run-cpu-e2e

MrPresent-Han avatar May 04 '23 03:05 MrPresent-Han