milvus icon indicating copy to clipboard operation
milvus copied to clipboard

Support parse json expr

Open xiaocai2333 opened this issue 2 years ago • 12 comments

/kind improvement

xiaocai2333 avatar Apr 27 '23 03:04 xiaocai2333

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiaocai2333 To complete the pull request process, please assign wxyucs after the PR has been reviewed. You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Apr 27 '23 03:04 sre-ci-robot

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 27 '23 03:04 mergify[bot]

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 27 '23 03:04 mergify[bot]

Codecov Report

Merging #23748 (07fa56f) into master (016311a) will increase coverage by 0.01%. The diff coverage is 82.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23748      +/-   ##
==========================================
+ Coverage   82.02%   82.04%   +0.01%     
==========================================
  Files         744      744              
  Lines       97244    97336      +92     
==========================================
+ Hits        79765    79858      +93     
+ Misses      14514    14500      -14     
- Partials     2965     2978      +13     
Impacted Files Coverage Δ
internal/parser/planparserv2/plan_parser_v2.go 89.88% <ø> (ø)
internal/parser/planparserv2/parser_visitor.go 86.45% <79.26%> (-0.69%) :arrow_down:
internal/parser/planparserv2/utils.go 85.66% <100.00%> (+0.62%) :arrow_up:
pkg/util/typeutil/schema.go 71.21% <100.00%> (+0.24%) :arrow_up:

... and 29 files with indirect coverage changes

codecov[bot] avatar Apr 27 '23 03:04 codecov[bot]

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 27 '23 04:04 mergify[bot]

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 27 '23 04:04 mergify[bot]

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 27 '23 09:04 mergify[bot]

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 27 '23 09:04 mergify[bot]

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 27 '23 11:04 mergify[bot]

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 27 '23 11:04 mergify[bot]

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 27 '23 13:04 mergify[bot]

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 28 '23 01:04 mergify[bot]

/close see #23804

xiaocai2333 avatar May 04 '23 03:05 xiaocai2333

@xiaocai2333: Closed this PR.

In response to this:

/close see #23804

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sre-ci-robot avatar May 04 '23 03:05 sre-ci-robot