milvus icon indicating copy to clipboard operation
milvus copied to clipboard

[Enhancement]: Show "DEBUG" in Milvus banner when build debug image

Open cydrain opened this issue 2 years ago • 1 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

What would you like to be added?

Show "DEBUG" in Milvus banner when build debug image. By this way, we can know we're running a release image or a debug image.

Why is this needed?

No response

Anything else?

No response

cydrain avatar Apr 26 '23 08:04 cydrain

/assign

cydrain avatar Apr 26 '23 08:04 cydrain

knowhere has already supported to show "DEBUG" for debug build (https://github.com/milvus-io/knowhere/pull/860) When querynode / indexnode do knowhere initialization, we can see knowhere is running "DEBUG" or not.

I20230506 11:35:00.246528 51480 knowhere_config.cc:47] [KNOWHERE][ShowVersion][milvus] Knowhere Version: 6448cf09 (DEBUG)

For Milvus, don't know how do do similar things. Since Milvus and knowhere share the same build type, using knowhere to tell "DEBUG" or not is enough.

cydrain avatar May 12 '23 02:05 cydrain

/close

cydrain avatar May 12 '23 02:05 cydrain

@cydrain: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sre-ci-robot avatar May 12 '23 02:05 sre-ci-robot