milvus icon indicating copy to clipboard operation
milvus copied to clipboard

fix has collection cause panic

Open weiliu1031 opened this issue 2 years ago • 4 comments

Signed-off-by: Wei Liu [email protected] issue: #23707

weiliu1031 avatar Apr 25 '23 10:04 weiliu1031

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031 To complete the pull request process, please assign yanliang567 after the PR has been reviewed. You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Apr 25 '23 10:04 sre-ci-robot

@weiliu1031 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

mergify[bot] avatar Apr 25 '23 10:04 mergify[bot]

@weiliu1031 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 25 '23 11:04 mergify[bot]

why would it result in panic? it should return false if collection not there as expected?

xiaofan-luan avatar Apr 25 '23 17:04 xiaofan-luan

why would it result in panic? it should return false if collection not there as expected?

cause rootcoord.DescribeCollection will return ErrorCode_UnexpectedError, it will cause handler.HasCollection retry many times and finnally panic

weiliu1031 avatar Apr 25 '23 23:04 weiliu1031

why would it result in panic? it should return false if collection not there as expected?

cause rootcoord.DescribeCollection will return ErrorCode_UnexpectedError, it will cause handler.HasCollection retry many times and finnally panic

Fixed that by check unexpectedExcepton

xiaofan-luan avatar Apr 26 '23 01:04 xiaofan-luan