milvus
milvus copied to clipboard
Fix global rateCollector init multiple times
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: congqixia
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~internal/datanode/OWNERS~~ [congqixia]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
Codecov Report
Merging #23703 (0c2c46b) into master (4fb8919) will increase coverage by
0.03%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #23703 +/- ##
==========================================
+ Coverage 82.11% 82.15% +0.03%
==========================================
Files 742 742
Lines 96994 96999 +5
==========================================
+ Hits 79647 79688 +41
+ Misses 14378 14354 -24
+ Partials 2969 2957 -12
| Impacted Files | Coverage Δ | |
|---|---|---|
| internal/datanode/data_node.go | 73.59% <100.00%> (-0.08%) |
:arrow_down: |
| internal/datanode/rate_collector.go | 91.17% <100.00%> (+1.89%) |
:arrow_up: |
/lgtm