milvus icon indicating copy to clipboard operation
milvus copied to clipboard

Optimize log when rootcoord goroutine quit

Open longjiquan opened this issue 2 years ago • 5 comments

/kind improvement

longjiquan avatar Apr 25 '23 08:04 longjiquan

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 25 '23 09:04 mergify[bot]

/run-cpu-e2e

longjiquan avatar Apr 25 '23 09:04 longjiquan

Codecov Report

Merging #23698 (98e3503) into master (4fb8919) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23698   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files         742      742           
  Lines       96994    96996    +2     
=======================================
+ Hits        79647    79649    +2     
- Misses      14378    14379    +1     
+ Partials     2969     2968    -1     
Impacted Files Coverage Δ
internal/rootcoord/root_coord.go 80.22% <100.00%> (+0.01%) :arrow_up:

... and 8 files with indirect coverage changes

codecov[bot] avatar Apr 25 '23 09:04 codecov[bot]

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 25 '23 10:04 mergify[bot]

/run-cpu-e2e

longjiquan avatar Apr 26 '23 01:04 longjiquan

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 26 '23 02:04 mergify[bot]

/run-cpu-e2e

longjiquan avatar Apr 26 '23 02:04 longjiquan

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 26 '23 02:04 mergify[bot]

/run-cpu-e2e

longjiquan avatar Apr 29 '23 06:04 longjiquan

/approve /lgtm

czs007 avatar Apr 29 '23 08:04 czs007

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Apr 29 '23 08:04 sre-ci-robot