milvus icon indicating copy to clipboard operation
milvus copied to clipboard

refine balance to replica granuity

Open MrPresent-Han opened this issue 2 years ago • 13 comments

related: #23454

MrPresent-Han avatar Apr 23 '23 09:04 MrPresent-Han

@MrPresent-Han Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

mergify[bot] avatar Apr 23 '23 09:04 mergify[bot]

@MrPresent-Han ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 23 '23 10:04 mergify[bot]

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 23 '23 10:04 mergify[bot]

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 23 '23 11:04 mergify[bot]

@MrPresent-Han ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 23 '23 11:04 mergify[bot]

@MrPresent-Han ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 24 '23 04:04 mergify[bot]

rerun ut

MrPresent-Han avatar Apr 24 '23 05:04 MrPresent-Han

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 24 '23 06:04 mergify[bot]

Codecov Report

Merging #23629 (022d313) into 2.2.0 (cb82783) will decrease coverage by 0.02%. The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #23629      +/-   ##
==========================================
- Coverage   80.62%   80.60%   -0.02%     
==========================================
  Files         717      717              
  Lines      101499   101509      +10     
==========================================
- Hits        81837    81826      -11     
- Misses      16451    16467      +16     
- Partials     3211     3216       +5     
Impacted Files Coverage Δ
internal/metrics/querycoord_metrics.go 100.00% <ø> (ø)
internal/querycoordv2/task/scheduler.go 78.00% <66.66%> (-0.54%) :arrow_down:
internal/querycoordv2/balance/utils.go 76.25% <100.00%> (ø)
internal/querycoordv2/checkers/balance_checker.go 97.53% <100.00%> (ø)
internal/querycoordv2/job/job.go 84.11% <100.00%> (+0.23%) :arrow_up:
internal/querycoordv2/task/executor.go 69.66% <100.00%> (ø)

... and 14 files with indirect coverage changes

codecov[bot] avatar Apr 24 '23 06:04 codecov[bot]

/run-cpu-e2e

MrPresent-Han avatar Apr 24 '23 08:04 MrPresent-Han

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 24 '23 09:04 mergify[bot]

/run-cpu-e2e

MrPresent-Han avatar Apr 24 '23 11:04 MrPresent-Han

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, MrPresent-Han

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Apr 25 '23 08:04 sre-ci-robot