natsmq

[yiwangdr]

@jaime0815 This PR contains my code for Nats MQ. I will keep updating it until I explicitly sign off. Let's sync on the progress and planning when I sign off.

My idea is that we can keep all the initial nats mq implementation discussions and comments in one place for future reference.

issue: #23611

[sre-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yiwangdr To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed. You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[mergify[bot]]

@yiwangdr Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

[mergify[bot]]

@yiwangdr, please be sure the pr should only have one commit, check https://github.com/milvus-io/milvus/blob/master/CODE_REVIEW.md for more details.

[mergify[bot]]

@yiwangdr ut workflow job failed, comment rerun ut can trigger the job again.

[codecov[bot]]

Codecov Report

Merging #23606 (e91597e) into master (6653e2c) will increase coverage by 0.02%. The diff coverage is 84.55%.

@@            Coverage Diff             @@
##           master   #23606      +/-   ##
==========================================
+ Coverage   82.04%   82.06%   +0.02%     
==========================================
  Files         742      749       +7     
  Lines       96922    97181     +259     
==========================================
+ Hits        79516    79750     +234     
- Misses      14446    14454       +8     
- Partials     2960     2977      +17     

Impacted Files	Coverage Δ
internal/mq/mqimpl/natsmq/server/global_nmq.go	75.00% <75.00%> (ø)
internal/mq/msgstream/mqwrapper/nmq/nmq_client.go	76.13% <76.13%> (ø)
...nternal/mq/msgstream/mqwrapper/nmq/nmq_producer.go	81.25% <81.25%> (ø)
...nternal/mq/msgstream/mqwrapper/nmq/nmq_consumer.go	90.90% <90.90%> (ø)
internal/mq/msgstream/nmq_factory.go	92.30% <92.30%> (ø)
internal/mq/msgstream/mqwrapper/nmq/nmq_id.go	100.00% <100.00%> (ø)
internal/mq/msgstream/mqwrapper/nmq/nmq_message.go	100.00% <100.00%> (ø)

... and 11 files with indirect coverage changes

[mergify[bot]]

@yiwangdr ut workflow job failed, comment rerun ut can trigger the job again.

[xiaofan-luan]

Hi @yiwangdr You will need a issue describe what you try to contribute, and related the pr with issue. Also you will have to sign the DCO, check the CONTRIBUTING Guide here https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md

[yiwangdr]

Hi @yiwangdr You will need a issue describe what you try to contribute, and related the pr with issue. Also you will have to sign the DCO, check the CONTRIBUTING Guide here https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md

Thanks, I'm aware of that. Please correct me if I'm wrong. I noticed that there is a "one commit only" policy. I'm not familiar with how that works if we have multiple contributors yet.

So this is a draft PR where I can keep commit history. @jaime0815 and other team members can commit to it as well.

We will have a separate PR with one commit for review & merge.

[mergify[bot]]

@yiwangdr ut workflow job failed, comment rerun ut can trigger the job again.

[jiaoew1991]

Hi @yiwangdr You will need a issue describe what you try to contribute, and related the pr with issue. Also you will have to sign the DCO, check the CONTRIBUTING Guide here https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md

Thanks, I'm aware of that. Please correct me if I'm wrong. I noticed that there is a "one commit only" policy. I'm not familiar with how that works if we have multiple contributors yet.

So this is a draft PR where I can keep commit history. @jaime0815 and other team members can commit to it as well.

We will have a separate PR with one commit for review & merge.

During the development phase, there can be multiple commits, and before merging, someone needs to rebase the commits into one.

[jiaoew1991]

It's best to break down a large pull request into several small ones and merge them one by one 😄

[yiwangdr]

It's best to break down a large pull request into several small ones and merge them �one by one 😄

I agree. That's the preferred pattern. I noticed there are very big PRs in the codebase history thus thought big PRs are the pattern here. Thanks for pointing it out.

This PR is also experimental-ish. Will break it for review&merge if needed.

[mergify[bot]]

@yiwangdr ut workflow job failed, comment rerun ut can trigger the job again.

[mergify[bot]]

@yiwangdr ut workflow job failed, comment rerun ut can trigger the job again.

[yiwangdr]

rerun ut

[mergify[bot]]

@yiwangdr ut workflow job failed, comment rerun ut can trigger the job again.