milvus icon indicating copy to clipboard operation
milvus copied to clipboard

Fix bug for statistical metrics is incorrect

Open xiaocai2333 opened this issue 3 years ago • 4 comments

Signed-off-by: cai.zhang [email protected] /kind improvement

xiaocai2333 avatar Sep 22 '22 03:09 xiaocai2333

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Sep 22 '22 03:09 mergify[bot]

rerun ut

xiaocai2333 avatar Sep 22 '22 07:09 xiaocai2333

Codecov Report

Merging #19357 (46c2efb) into master (c58a8d8) will decrease coverage by 0.20%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19357      +/-   ##
==========================================
- Coverage   81.01%   80.80%   -0.21%     
==========================================
  Files         668      668              
  Lines       94571    94615      +44     
==========================================
- Hits        76619    76457     -162     
- Misses      14696    14902     +206     
  Partials     3256     3256              
Impacted Files Coverage Δ
internal/indexcoord/meta_table.go 95.58% <100.00%> (+0.64%) :arrow_up:
internal/metrics/indexcoord_metrics.go 100.00% <100.00%> (ø)
internal/querycoordv2/meta/coordinator_broker.go 34.42% <0.00%> (-32.79%) :arrow_down:
internal/querycoordv2/utils/types.go 78.12% <0.00%> (-21.88%) :arrow_down:
internal/querynode/impl_utils.go 0.00% <0.00%> (-17.40%) :arrow_down:
internal/querycoordv2/task/utils.go 71.89% <0.00%> (-16.34%) :arrow_down:
internal/querynode/task_statistics.go 47.11% <0.00%> (-11.54%) :arrow_down:
internal/querycoordv2/dist/dist_handler.go 76.05% <0.00%> (-9.16%) :arrow_down:
internal/querynode/shard_cluster.go 89.90% <0.00%> (-4.51%) :arrow_down:
internal/querycoordv2/observers/leader_observer.go 86.59% <0.00%> (-4.13%) :arrow_down:
... and 31 more

codecov[bot] avatar Sep 22 '22 07:09 codecov[bot]

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Sep 23 '22 07:09 mergify[bot]

rerun ut

xiaocai2333 avatar Sep 23 '22 08:09 xiaocai2333

/approve /lgtm

czs007 avatar Sep 23 '22 09:09 czs007

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 26 '22 03:09 mergify[bot]

/run-cpu-e2e

xiaocai2333 avatar Sep 26 '22 06:09 xiaocai2333

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 26 '22 09:09 mergify[bot]

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 26 '22 09:09 mergify[bot]

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Sep 26 '22 09:09 mergify[bot]

rerun ut

xiaocai2333 avatar Sep 26 '22 12:09 xiaocai2333

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 26 '22 12:09 mergify[bot]

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Sep 26 '22 12:09 mergify[bot]

/approve

czs007 avatar Sep 27 '22 03:09 czs007

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Sep 27 '22 03:09 sre-ci-robot

/lgtm

LoveEachDay avatar Sep 27 '22 09:09 LoveEachDay

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 27 '22 10:09 mergify[bot]

/run-cpu-e2e

xiaocai2333 avatar Sep 27 '22 11:09 xiaocai2333

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 27 '22 11:09 mergify[bot]

/run-cpu-e2e

xiaocai2333 avatar Sep 27 '22 11:09 xiaocai2333

/lgtm

czs007 avatar Sep 28 '22 03:09 czs007