milvus icon indicating copy to clipboard operation
milvus copied to clipboard

Add ut for IndexCoord

Open xiaocai2333 opened this issue 3 years ago • 5 comments

Signed-off-by: zhuwenxing [email protected] issue: #18642

xiaocai2333 avatar Sep 21 '22 12:09 xiaocai2333

@xiaocai2333 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

mergify[bot] avatar Sep 21 '22 12:09 mergify[bot]

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Sep 21 '22 12:09 mergify[bot]

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 21 '22 12:09 mergify[bot]

Codecov Report

Merging #19349 (709c74c) into master (4288401) will increase coverage by 0.20%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19349      +/-   ##
==========================================
+ Coverage   80.25%   80.46%   +0.20%     
==========================================
  Files         673      673              
  Lines       94152    94133      -19     
==========================================
+ Hits        75566    75746     +180     
+ Misses      15323    15156     -167     
+ Partials     3263     3231      -32     
Impacted Files Coverage Δ
internal/indexcoord/garbage_collector.go 92.77% <ø> (+24.84%) :arrow_up:
internal/indexcoord/index_builder.go 99.73% <100.00%> (+33.23%) :arrow_up:
internal/indexcoord/meta_table.go 95.98% <100.00%> (+0.73%) :arrow_up:
internal/querycoord/channel_unsubscribe.go 80.17% <0.00%> (-2.59%) :arrow_down:
internal/proxy/channels_time_ticker.go 80.59% <0.00%> (-2.24%) :arrow_down:
internal/datacoord/segment_manager.go 83.14% <0.00%> (-2.21%) :arrow_down:
internal/util/grpcclient/client.go 94.37% <0.00%> (-1.88%) :arrow_down:
internal/mq/mqimpl/rocksmq/client/client_impl.go 77.96% <0.00%> (-1.70%) :arrow_down:
internal/mq/msgstream/mq_msgstream.go 78.04% <0.00%> (-0.85%) :arrow_down:
internal/querycoord/query_coord.go 76.82% <0.00%> (-0.57%) :arrow_down:
... and 13 more

codecov[bot] avatar Sep 22 '22 01:09 codecov[bot]

/approve /lgtm

czs007 avatar Sep 23 '22 01:09 czs007

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Sep 23 '22 01:09 sre-ci-robot