milvus
milvus copied to clipboard
milvus-io
Optimize large memory usage of InsertRecord by using vector instead of unordered_map if InsertRecord used in sealed segment
related:https://github.com/milvus-io/milvus/issues/18764 https://github.com/milvus-io/milvus/issues/18845 Signed-off-by: aoiasd [email protected]
@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
![mergify[bot] avatar](https://avatars.githubusercontent.com/in/10562?v=4 "Published by a pub.dev verified publisher"){kind=small}
@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
Codecov Report
Merging #19245 (44cdef3) into master (72ee35a) will increase coverage by
0.02%. The diff coverage is93.96%.
@@ Coverage Diff @@
## master #19245 +/- ##
==========================================
+ Coverage 80.25% 80.28% +0.02%
==========================================
Files 673 673
Lines 94174 94203 +29
==========================================
+ Hits 75581 75632 +51
+ Misses 15326 15313 -13
+ Partials 3267 3258 -9
| Impacted Files | Coverage Δ | |
|---|---|---|
| internal/core/src/query/SearchOnSealed.cpp | 100.00% <ø> (ø) |
|
| internal/core/src/segcore/FieldIndexing.cpp | 97.05% <ø> (-0.38%) |
:arrow_down: |
| internal/core/src/segcore/SegmentGrowingImpl.h | 82.85% <ø> (ø) |
|
| internal/core/src/segcore/SegmentSealedImpl.cpp | 79.79% <ø> (ø) |
|
| internal/core/src/segcore/SegmentSealedImpl.h | 80.00% <ø> (ø) |
|
| internal/core/src/segcore/Utils.cpp | 70.96% <ø> (-3.20%) |
:arrow_down: |
| internal/core/src/segcore/InsertRecord.h | 92.17% <91.66%> (-7.83%) |
:arrow_down: |
| internal/core/src/segcore/FieldIndexing.h | 97.61% <100.00%> (+0.74%) |
:arrow_up: |
| internal/core/src/segcore/Utils.h | 100.00% <100.00%> (ø) |
|
| ... and 19 more |
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@aoiasd ut workflow job failed, comment rerun ut can trigger the job again.
@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: aoiasd, congqixia
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~internal/core/OWNERS~~ [congqixia]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
