milvus icon indicating copy to clipboard operation
milvus copied to clipboard

Add more log when creating index, Finished/Failed index will not be c…

Open xiaofan-luan opened this issue 3 years ago • 5 comments

  1. Add more logs in index node task
  2. finished and failed task will not be counted in index job

Signed-off-by: xiaofan-luan [email protected]

xiaofan-luan avatar Sep 10 '22 09:09 xiaofan-luan

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Sep 10 '22 09:09 sre-ci-robot

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 10 '22 09:09 mergify[bot]

Codecov Report

Merging #19150 (2d20508) into master (10c0ff1) will decrease coverage by 0.47%. The diff coverage is 82.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19150      +/-   ##
==========================================
- Coverage   80.76%   80.29%   -0.48%     
==========================================
  Files         657      673      +16     
  Lines       93123    94217    +1094     
==========================================
+ Hits        75215    75649     +434     
- Misses      14663    15301     +638     
- Partials     3245     3267      +22     
Impacted Files Coverage Δ
internal/indexnode/task.go 54.21% <54.54%> (-20.38%) :arrow_down:
internal/indexnode/indexnode_service.go 89.77% <100.00%> (+0.04%) :arrow_up:
internal/indexnode/task_scheduler.go 88.96% <100.00%> (+0.31%) :arrow_up:
internal/indexnode/taskinfo_ops.go 95.52% <100.00%> (+9.58%) :arrow_up:
internal/core/src/common/Utils.h 77.27% <0.00%> (-22.73%) :arrow_down:
internal/core/src/index/StringIndex.h 85.71% <0.00%> (-14.29%) :arrow_down:
internal/util/indexcgowrapper/index.go 70.14% <0.00%> (-12.82%) :arrow_down:
internal/util/indexcgowrapper/helper.go 62.71% <0.00%> (-10.02%) :arrow_down:
internal/querynode/load_index_info.go 67.81% <0.00%> (-5.87%) :arrow_down:
... and 106 more

codecov[bot] avatar Sep 10 '22 10:09 codecov[bot]

@xiaofan-luan ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Sep 15 '22 09:09 mergify[bot]

@xiaofan-luan ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Sep 21 '22 13:09 mergify[bot]

/lgtm

xiaocai2333 avatar Sep 23 '22 01:09 xiaocai2333