milvus icon indicating copy to clipboard operation
milvus copied to clipboard

Fix Chunk Manager Path mis use

Open xiaofan-luan opened this issue 3 years ago • 8 comments

ralated to #19138 fix the issue that Minio chunk manager misuse local path Signed-off-by: xiaofan-luan [email protected]

xiaofan-luan avatar Sep 09 '22 09:09 xiaofan-luan

@xiaofan-luan ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Sep 09 '22 09:09 mergify[bot]

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 09 '22 11:09 mergify[bot]

@xiaofan-luan ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Sep 09 '22 11:09 mergify[bot]

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 21 '22 12:09 mergify[bot]

@xiaofan-luan ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Sep 21 '22 12:09 mergify[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Sep 21 '22 12:09 sre-ci-robot

@xiaofan-luan ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Sep 21 '22 13:09 mergify[bot]

Codecov Report

Merging #19141 (603f04f) into master (10c0ff1) will decrease coverage by 0.50%. The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19141      +/-   ##
==========================================
- Coverage   80.76%   80.26%   -0.51%     
==========================================
  Files         657      673      +16     
  Lines       93123    94131    +1008     
==========================================
+ Hits        75215    75554     +339     
- Misses      14663    15316     +653     
- Partials     3245     3261      +16     
Impacted Files Coverage Δ
internal/indexnode/chunkmgr_mock.go 48.03% <0.00%> (ø)
internal/querycoordv2/server.go 74.44% <ø> (+0.53%) :arrow_up:
internal/util/dependency/factory.go 40.00% <50.00%> (+6.66%) :arrow_up:
internal/querynode/query_shard_service.go 95.34% <55.55%> (-4.66%) :arrow_down:
internal/querynode/query_node.go 81.41% <83.33%> (+1.56%) :arrow_up:
internal/datacoord/garbage_collector.go 77.85% <100.00%> (ø)
internal/datacoord/server.go 76.80% <100.00%> (+0.54%) :arrow_up:
internal/datanode/data_node.go 82.66% <100.00%> (ø)
internal/indexcoord/index_coord.go 70.55% <100.00%> (+0.03%) :arrow_up:
internal/indexnode/chunk_mgr_factory.go 80.00% <100.00%> (+3.07%) :arrow_up:
... and 111 more

codecov[bot] avatar Sep 21 '22 15:09 codecov[bot]

/lgtm

jaime0815 avatar Sep 23 '22 06:09 jaime0815