milvus icon indicating copy to clipboard operation
milvus copied to clipboard

Fix missing handling channels while node down

Open xiaofan-luan opened this issue 3 years ago • 4 comments

related to #18250 Signed-off-by: xiaofan-luan [email protected]

xiaofan-luan avatar Jul 19 '22 02:07 xiaofan-luan

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Jul 19 '22 02:07 sre-ci-robot

Codecov Report

Merging #18317 (6a89bff) into 2.1.0 (0e4dc11) will increase coverage by 0.04%. The diff coverage is 83.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.1.0   #18317      +/-   ##
==========================================
+ Coverage   81.28%   81.32%   +0.04%     
==========================================
  Files         476      476              
  Lines       75424    75498      +74     
==========================================
+ Hits        61305    61400      +95     
+ Misses      11446    11429      -17     
+ Partials     2673     2669       -4     
Impacted Files Coverage Δ
internal/querycoord/handoff_handler.go 78.37% <62.50%> (-1.55%) :arrow_down:
internal/querycoord/task_scheduler.go 78.45% <75.00%> (+0.34%) :arrow_up:
internal/querycoord/query_coord.go 77.52% <83.33%> (+4.39%) :arrow_up:
internal/querycoord/channel_unsubscribe.go 80.17% <87.20%> (-2.44%) :arrow_down:
internal/querycoord/cluster.go 80.38% <100.00%> (ø)
internal/querycoord/meta.go 79.44% <100.00%> (ø)
internal/querycoord/task.go 77.81% <100.00%> (+0.47%) :arrow_up:
internal/util/paramtable/component_param.go 89.44% <100.00%> (+0.14%) :arrow_up:
internal/querycoord/global_meta_broker.go 70.04% <0.00%> (-4.51%) :arrow_down:
internal/distributed/querycoord/client/client.go 71.14% <0.00%> (-2.00%) :arrow_down:
... and 19 more

codecov[bot] avatar Jul 19 '22 02:07 codecov[bot]

It would be better to hold this PR until the issue https://github.com/milvus-io/milvus/issues/18316 is fixed

zhuwenxing avatar Jul 19 '22 03:07 zhuwenxing

/hold

zhuwenxing avatar Jul 19 '22 03:07 zhuwenxing

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale[bot] avatar Sep 11 '22 18:09 stale[bot]