milvus icon indicating copy to clipboard operation
milvus copied to clipboard

Add channel checkpoint

Open sunby opened this issue 3 years ago • 12 comments

issue: https://github.com/milvus-io/milvus/issues/17445 Signed-off-by: sunby [email protected]

sunby avatar Jul 06 '22 09:07 sunby

@sunby E2e jenkins job failed, comment /run-checks can trigger the job again.

mergify[bot] avatar Jul 06 '22 09:07 mergify[bot]

@sunby ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Jul 06 '22 09:07 mergify[bot]

@sunby E2e jenkins job failed, comment /run-checks can trigger the job again.

mergify[bot] avatar Jul 06 '22 10:07 mergify[bot]

@sunby ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Jul 06 '22 10:07 mergify[bot]

@congqixia pls also help on reviewing it, thanks

xiaofan-luan avatar Jul 06 '22 12:07 xiaofan-luan

@sunby E2e jenkins job failed, comment /run-checks can trigger the job again.

mergify[bot] avatar Jul 07 '22 09:07 mergify[bot]

Codecov Report

Merging #18114 (ed3c8e6) into master (e61f61a) will increase coverage by 0.02%. The diff coverage is 80.31%.

:exclamation: Current head ed3c8e6 differs from pull request most recent head e71ef8a. Consider uploading reports for the commit e71ef8a to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18114      +/-   ##
==========================================
+ Coverage   81.86%   81.88%   +0.02%     
==========================================
  Files         477      477              
  Lines       75647    75779     +132     
==========================================
+ Hits        61926    62055     +129     
+ Misses      10996    10994       -2     
- Partials     2725     2730       +5     
Impacted Files Coverage Δ
internal/datacoord/server.go 75.81% <40.00%> (-0.30%) :arrow_down:
internal/datacoord/meta.go 85.29% <50.00%> (-2.21%) :arrow_down:
internal/datanode/flow_graph_time_ticker.go 96.34% <80.00%> (+0.18%) :arrow_up:
internal/datanode/segment_replica.go 91.78% <88.78%> (-0.59%) :arrow_down:
internal/datanode/flow_graph_delete_node.go 81.99% <94.73%> (+1.27%) :arrow_up:
internal/datacoord/handler.go 96.77% <100.00%> (+2.71%) :arrow_up:
internal/datanode/flow_graph_insert_buffer_node.go 93.76% <100.00%> (-0.10%) :arrow_down:
internal/datanode/flush_manager.go 93.35% <100.00%> (-0.07%) :arrow_down:
internal/mq/mqimpl/rocksmq/client/client_impl.go 77.96% <0.00%> (-2.55%) :arrow_down:
internal/indexcoord/garbage_collector.go 93.68% <0.00%> (-2.55%) :arrow_down:
... and 27 more

codecov[bot] avatar Jul 07 '22 09:07 codecov[bot]

@sunby ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Jul 07 '22 09:07 mergify[bot]

@sunby E2e jenkins job failed, comment /run-checks can trigger the job again.

mergify[bot] avatar Jul 08 '22 02:07 mergify[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunby To complete the pull request process, please ask for approval from xiaofan-luan after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Jul 11 '22 07:07 sre-ci-robot

@sunby ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Jul 11 '22 08:07 mergify[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale[bot] avatar Aug 10 '22 12:08 stale[bot]