milvus icon indicating copy to clipboard operation
milvus copied to clipboard

[Bug]: [tls] No type check for "secure" parameter in "connect" interface

Open binbinlv opened this issue 3 years ago • 6 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Environment

- Milvus version: latest
- Deployment mode(standalone or cluster): both
- SDK version(e.g. pymilvus v2.0.0rc2): 2.1.0.dev60
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

No type check for "secure" parameter in "connect" interface

Expected Behavior

 * *secure* (``bool``) --
                Optional. Default is false. If set to true, tls will be enabled.

Steps To Reproduce

connections.connect(host=***, port="19530", secure="string", client_key_path="/milvus/configs/cert/client.key", client_pem_path="/milvus/configs/cert/client.pem", ca_pem_path="/milvus/configs/cert/ca.pem", server_name="localhost")

Milvus Log

NA

Anything else?

No response

binbinlv avatar May 19 '22 09:05 binbinlv

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale[bot] avatar Jun 18 '22 13:06 stale[bot]

/reopen

xiaofan-luan avatar Jun 19 '22 01:06 xiaofan-luan

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale[bot] avatar Jul 22 '22 01:07 stale[bot]

Keep opening

binbinlv avatar Jul 22 '22 06:07 binbinlv

/assign @aakejiang pls help on it

xiaofan-luan avatar Aug 10 '22 15:08 xiaofan-luan

@xiaofan-luan: GitHub didn't allow me to assign the following users: pls, help, on, it.

Note that only milvus-io members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to this:

/assign @aakejiang pls help on it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sre-ci-robot avatar Aug 10 '22 15:08 sre-ci-robot

/unassign @aakejiang /assign

XuanYang-cn avatar Aug 18 '22 06:08 XuanYang-cn

pymilvus-2.2.0.dev30 /unassign /assign @binbinlv

XuanYang-cn avatar Sep 08 '22 08:09 XuanYang-cn

Fixed and close this issue. Name: pymilvus Version: 2.2.0.dev30

>>> connections.connect(host="10.100.31.107", port="19530", secure="string")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/binbin/embedded-test-env-3.8/lib/python3.8/site-packages/pymilvus/orm/connections.py", line 300, in connect
    connect_milvus(**kwargs, password=password)
  File "/binbin/embedded-test-env-3.8/lib/python3.8/site-packages/pymilvus/orm/connections.py", line 270, in connect_milvus
    gh = GrpcHandler(**kwargs)
  File "/binbin/embedded-test-env-3.8/lib/python3.8/site-packages/pymilvus/client/grpc_handler.py", line 84, in __init__
    self._set_authorization(**kwargs)
  File "/binbin/embedded-test-env-3.8/lib/python3.8/site-packages/pymilvus/client/grpc_handler.py", line 100, in _set_authorization
    raise ParamError("secure must be bool type")
pymilvus.exceptions.ParamError: secure must be bool type

binbinlv avatar Sep 08 '22 09:09 binbinlv