milvus-sdk-rust icon indicating copy to clipboard operation
milvus-sdk-rust copied to clipboard

[Feature]: Change Has_XXX functions into Describe_XXX

Open jiaoew1991 opened this issue 2 years ago • 4 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Is your feature request related to a problem? Please describe.

All of the Milvus API changed, the Has_XXX functions will be deprecated in the future version

Describe the solution you'd like.

No response

Describe an alternate solution.

No response

Anything else? (Additional Context)

No response

jiaoew1991 avatar Oct 17 '23 00:10 jiaoew1991

Hey @jiaoew1991 When i searched has_ funtions there are 1.1 K files in the master repo mentioning the function...so could you help me which ones need to be changed?

Smartmind12 avatar Oct 24 '23 06:10 Smartmind12

Hey @jiaoew1991 When i searched has_ funtions there are 1.1 K files in the master repo mentioning the function...so could you help me which ones need to be changed?

@yah01 Could you help @Smartmind12 point out what needs to be changed

jiaoew1991 avatar Oct 24 '23 16:10 jiaoew1991

Hi @Smartmind12, the Milvus server deprecated the HasXxx APIs, the SDK would keep the API but change the impl, like has_collection method in src/client.rs, it calls the HasCollection API of Milvus Server, we need to change it to call DescribeCollection API.

I just checked, only has_collection in src/client.rs and has_partition in src/collection.rs need to be changed

yah01 avatar Oct 26 '23 02:10 yah01

Hi @Smartmind12, the Milvus server deprecated the HasXxx APIs, the SDK would keep the API but change the impl, like has_collection method in src/client.rs, it calls the HasCollection API of Milvus Server, we need to change it to call DescribeCollection API.

I just checked, only has_collection in src/client.rs and has_partition in src/collection.rs need to be changed

Thanks and I understand and will do the needful!

Smartmind12 avatar Oct 26 '23 04:10 Smartmind12