milvus-sdk-go icon indicating copy to clipboard operation
milvus-sdk-go copied to clipboard

Implement SearchByPks (work in progress)

Open unfode opened this issue 2 years ago • 4 comments

Implement SearchByPks in Go SDK corresponding to the newly added SearchByPks endpoint in Milvus (https://github.com/milvus-io/milvus/pull/25882)

unfode avatar Oct 17 '23 16:10 unfode

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: unfode To complete the pull request process, please assign yah01 after the PR has been reviewed. You can assign the PR to them by writing /assign @yah01 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Oct 17 '23 16:10 sre-ci-robot

Welcome @unfode! It looks like this is your first PR to milvus-io/milvus-sdk-go 🎉

sre-ci-robot avatar Oct 17 '23 16:10 sre-ci-robot

Codecov Report

Attention: Patch coverage is 48.88889% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 81.90%. Comparing base (647cbab) to head (13fce3c). Report is 36 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #600      +/-   ##
==========================================
- Coverage   82.85%   81.90%   -0.96%     
==========================================
  Files          40       40              
  Lines        3640     3681      +41     
==========================================
- Hits         3016     3015       -1     
- Misses        512      555      +43     
+ Partials      112      111       -1     
Files Coverage Δ
client/client.go 28.94% <ø> (ø)
client/data.go 61.35% <48.88%> (-7.65%) :arrow_down:

codecov[bot] avatar Oct 18 '23 02:10 codecov[bot]

/cc @congqixia

yah01 avatar Oct 19 '23 03:10 yah01