milvus-sdk-cpp icon indicating copy to clipboard operation
milvus-sdk-cpp copied to clipboard

fix build warnings

Open Monster880 opened this issue 1 year ago • 4 comments

fix build warnings

Monster880 avatar May 30 '24 07:05 Monster880

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Monster880 To complete the pull request process, please assign matrixji after the PR has been reviewed. You can assign the PR to them by writing /assign @matrixji in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 30 '24 07:05 sre-ci-robot

Welcome @Monster880! It looks like this is your first PR to milvus-io/milvus-sdk-cpp 🎉

sre-ci-robot avatar May 30 '24 07:05 sre-ci-robot

/assign @matrixji

Monster880 avatar May 30 '24 07:05 Monster880

Hi, @Monster880 Thanks for your contributions, the clang-format-check failed, you should follow the code-style-for-milvus-c-sdk guide to do clang-format locally before raising PR.

matrixji avatar May 30 '24 12:05 matrixji

The code change has been merged into this pr: https://github.com/milvus-io/milvus-sdk-cpp/pull/308

yhmo avatar Aug 19 '25 06:08 yhmo

@Monster880 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

mergify[bot] avatar Aug 19 '25 06:08 mergify[bot]