Milos Gajdos

Sorry, I'm currently on sabbatical only accessing GH from my phone from random locations around the world so won't be able to give much proper feedback for a while I'm...

> Hi @milosgajdos , it's done. Thanks, one more thing, mind squashing @gotgelf ?

Can you please confirm what version of `registry` are you running?

> Thanks for the quick reply, the version is https://github.com/distribution/distribution/tree/v2.7.1 Ooof, that's what I suspected. That's an _ancient_ registry release. There have been a few news ones over the past...

> Thanks for the pointer! Looking at the distribution master code, though, it seems the problem still exists unless we have a way to pass in ExpiryWindow for AWS S3...

It seems we are hardcoding the expiry on the presigned URL to 20 minutes: https://github.com/distribution/distribution/blob/38beeee2c8d88c7a87e5563844aa157ea5615144/registry/storage/driver/s3-aws/s3.go#L1046 We can make this configurable, indeed. It'd be useful on slow networks when pulling large...

This is failing e2e (and conformance) tests but passing unit tests 🤔

I've rebased this PR @thaJeztah I might have some spare cycles to look into this tomorrow.

Thanks, @thaJeztah, I've found the cause. The new version of `gopkg.in/yaml.v3` now parses generic k/v in the YAML differently. See this commit: https://github.com/go-yaml/yaml/commit/14f799f057e7323ad4dfffa6f70641b091e51bf6 I am not entirely sure why the...

> I am not entirely sure why the e2e / run-e2e-test-s3-storage workflow is failing because the tests pass on my laptop 🤔 Ok, found the cause the tests fail, but...