intel_nuc_led icon indicating copy to clipboard operation
intel_nuc_led copied to clipboard

Published 20 hours ago • verified publisher icon milesp20

fix build with kernel 5.6-rc1

Open MilhouseVH opened this issue 5 years ago • 4 comments

Quick & dirty fix for 5.6-rc1. No problem if you'd rather fix this another way without the #ifdef.

Ref: https://github.com/torvalds/linux/commit/d56c0d45f0e27f814e87a1676b6bdccccbc252e9

MilhouseVH avatar Feb 10 '20 11:02 MilhouseVH

Thanks for this. Does this kernel change affect how nuc_led is interacted with? Is it still through /proc/acpi/nuc_led? I'm not seeing anything in /proc/acpi besides 'wakeup'.

$ cat /proc/acpi/nuc_led cat: /proc/acpi/nuc_led: No such file or directory $ ls /proc/acpi wakeup

On Ubuntu 18.04.3 (x64) on a NUC6CAY. This is after building and installing the .deb package (built using your patch to nuc_led.c).

GoTeamScotch avatar Mar 23 '20 10:03 GoTeamScotch

Unfortunately I don't know - I'm patching this blind as I don't have any LED hardware on my Skylake NUC6i5SYH. I only see /proc/acpi/wakeup with kernels 5.5.11 and 5.6-rc7. I'll see if I can find someone with the appropriate LED hardware...

MilhouseVH avatar Mar 25 '20 06:03 MilhouseVH

@MilhouseVH On my NUC with kernel 5.6.7 this patch works great! Especially the file /proc/acpi/nuc_led still appears and both reading and writing work fine.

zauguin avatar May 01 '20 14:05 zauguin

Thanks. Never did find anyone to test this, so it's already been removed from LibreELEC.

MilhouseVH avatar May 01 '20 14:05 MilhouseVH