goas icon indicating copy to clipboard operation
goas copied to clipboard

Update to urfave/cli introduces breaking changes

Open eking-isp opened this issue 6 years ago • 2 comments

This also broke https://github.com/swaggo/swag/issues/556, but you can no longer build this tool with the latest CLI since it recently introduced a breaking change:

..\mikunalpha\goas\main.go:13:16: cannot use cli.StringFlag literal (type cli.StringFlag) as type cli.Flag in array or slice literal:
        cli.StringFlag does not implement cli.Flag (Apply method has pointer receiver)
..\mikunalpha\goas\main.go:18:16: cannot use cli.StringFlag literal (type cli.StringFlag) as type cli.Flag in array or slice literal:
        cli.StringFlag does not implement cli.Flag (Apply method has pointer receiver)
..\mikunalpha\goas\main.go:23:16: cannot use cli.StringFlag literal (type cli.StringFlag) as type cli.Flag in array or slice literal:
        cli.StringFlag does not implement cli.Flag (Apply method has pointer receiver)
..\mikunalpha\goas\main.go:28:16: cannot use cli.StringFlag literal (type cli.StringFlag) as type cli.Flag in array or slice literal:
        cli.StringFlag does not implement cli.Flag (Apply method has pointer receiver)
..\mikunalpha\goas\main.go:33:14: cannot use cli.BoolFlag literal (type cli.BoolFlag) as type cli.Flag in array or slice literal:
        cli.BoolFlag does not implement cli.Flag (Apply method has pointer receiver)
..\mikunalpha\goas\main.go:40:23: c.GlobalString undefined (type *cli.Context has no field or method GlobalString)
..\mikunalpha\goas\main.go:40:120: c.GlobalBool undefined (type *cli.Context has no field or method GlobalBool)
..\mikunalpha\goas\main.go:45:26: c.GlobalString undefined (type *cli.Context has no field or method GlobalString)

eking-isp avatar Nov 27 '19 20:11 eking-isp

@eking-isp Do you recommend using urfave/cli v2 ?

mikunalpha avatar Nov 28 '19 01:11 mikunalpha

I do, yeah, at least until an upgrade plan is in place for it

eking-isp avatar Dec 02 '19 17:12 eking-isp