Michael Arthur
Michael Arthur
see #103
put extraFiles under linux, will apply to deb and all targets. works for me, can also make installer scripts if you need to copy them on install
I'm getting this on a Yellow, specifically home assistants oauth domain, which is odd. `account-link.nabucasa.com` happy to perform any tests to help resolve this.
> Please split this into two PRs Wondered if I'd get asked that, will do, I'll keep this one for one half and open a new one for the other
> Please split this into two PRs Moved Ecovacs to here https://github.com/home-assistant/core/pull/124519
> There is a binary sensor for the same function. I think this should be deprecated in another PR. > > https://github.com/home-assistant/core/blob/7ae8f4c9d0c261e86404883188b39e5b960ae1e0/homeassistant/components/husqvarna_automower/binary_sensor.py#L42-L45 > > Otherwise it looks good for me....
> > > There is a binary sensor for the same function. I think this should be deprecated in another PR. > > > https://github.com/home-assistant/core/blob/7ae8f4c9d0c261e86404883188b39e5b960ae1e0/homeassistant/components/husqvarna_automower/binary_sensor.py#L42-L45 > > > > >...
> Please split this into two PRs Can you update the labels? Or should I just reopen a new PR?
> > > There is a binary sensor for the same function. I think this should be deprecated in another PR. > > > https://github.com/home-assistant/core/blob/7ae8f4c9d0c261e86404883188b39e5b960ae1e0/homeassistant/components/husqvarna_automower/binary_sensor.py#L42-L45 > > > > >...
> Please at a test here: > > https://github.com/home-assistant/core/blob/f4528b288fbd04302852be41c99f47e2941fb2f2/tests/components/husqvarna_automower/test_lawn_mower.py#L43-L47 > > `("GOING_HOME", "IN_OPERATION", LawnMowerActivity.RETURNING),` Test added and passing.