Mike McKiernan

Results 35 comments of Mike McKiernan

This is in the nice-to-have category and not a blocking requirement for any release. I spotted one mistake (mine) in the models repo, in the `docs/source/conf.py` file, the "main/core" should...

@bschifferer , the very last link on this page is broken. It used to refer to the Outbrain example. My first instinct is to change it to refer to the...

> Here's my sugg replacement for the last sentence: ``` Refer to the API documentation for the {class}`Rename ` operator. ```

I found another change to make. In `docs/source/training/tensorflow.rst`, at the very end of the file, I think you/we/I can remove the link to outbrain and leave the movielens one.

> @mikemckiernan I updated the two files to fix the broken links - is that correct? Yep, the link looks good--it links into the API reference for `Rename`.

@chrisjsewell , please let me know if there's something I need to do before a review. Also, I'm completely open to suggestion on changes.

Yep, it'd be great if @choldgraf could peek and provide feedback. I appreciate everyone's time and help. Great project too!

I have _an implementation_ but want to kick the tires a little longer. I also want to know if a contribution for these items is welcome or if there's a...

Keeping some notes as I step through the process: * I think in models/example/04... we need the foll change: ```python # from workflow.save('workflow') # to workflow_path = os.path.join(DATA_FOLDER, "workflow") workflow.save(workflow_path)...