metrics icon indicating copy to clipboard operation
metrics copied to clipboard

ScheduledReporter enhancements

Open tolbertam opened this issue 8 years ago • 2 comments
trafficstars

After revisiting ScheduledReporter and its implementations for a bit, have a few ideas for enhancements:

  1. Add callback / promise support to report() that completes when all reporting duties are completed. This will allow the user to detect when reporting completes (so perhaps they can schedule another report if they want to control it manually) or fails.
  2. Using enhancement 1, only allow one in flight report at a time. While it seems unlikely, if there are concurrent reports happening at a time, you could have interlaced data.
  3. Allow CsvReporter and GraphiteReporter to be used without requiring user to call start. This would allow the user to manually control when data is reported with these reporters.
  4. Support duration and rate time unit configurations like dropwizard metrics does so user can request the time unit displayed in their reports.

tolbertam avatar Dec 28 '16 13:12 tolbertam

I think numbers 3 and 4 would require a version bump, which I'm fine with. These seem like reasonable additions to me.

mikejihbe avatar Dec 28 '16 20:12 mikejihbe

Can you shoot me an email at mike at mustwin .com, I'd like to discuss something else with you too

mikejihbe avatar Dec 28 '16 20:12 mikejihbe