metrics icon indicating copy to clipboard operation
metrics copied to clipboard

Wanted to see if you would be open to allowing flexibility on the route where metrics where exposed?

Open froozcode opened this issue 9 years ago • 2 comments
trafficstars

Looks like per server.js (/metrics) is the preferred endpoint where the data gets exposed. Would you be open to a pull request that would allow this to be changed? examples could be /stats, /health, etc. Basically whatever is passed in as a parameter. Thank you!

froozcode avatar May 25 '16 21:05 froozcode

I don't want to require a version bump, so we need to handle this function signature, but yes.

Let's make the first argument to https://github.com/mikejihbe/metrics/blob/master/reporting/server.js#L9 accept either a numerical port or an options object with port and path in it, then add some documentation.

On Wed, May 25, 2016 at 2:08 PM, Frank Ruiz [email protected] wrote:

Looks like per server.js (/metrics) is the preferred endpoint where the data gets exposed. Would you be open to a pull request that would allow this to be changed? examples could be /stats, /health, etc. Basically whatever is passed in as a parameter. Thank you!

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/mikejihbe/metrics/issues/34

Mike Ihbe MustWin - Principal

[email protected] [email protected] skype: mikeihbe Cell: 651.283.0815

mikejihbe avatar May 25 '16 22:05 mikejihbe

Awesome. I forked the repo, and will start making the necessary modifications. I'll send over a pull request shortly... thank you!

froozcode avatar May 26 '16 11:05 froozcode