Mike Hardy

Results 2210 comments of Mike Hardy

Thanks for reporting back with success - and glad it works, obviously! - reopening for implementation here

> any updates? I dunno, any reproducible example? Reports it works, reports it doesn't work And this is the *exact* problem new Expo developers get when they don't realize the...

Interesting, this is always difficult because this module is so fundamental people have a very very liberal idea of what "support for old versions" means and I wouldn't be surprised...

Here you can see we ask the system for battery status, and pull the extra constant that is supposed to tell us what the charge state is https://github.com/react-native-device-info/react-native-device-info/blob/1c85272a1714dfb41599ebc00557fb2e0bd5c45e/android/src/main/java/com/learnium/RNDeviceInfo/RNDeviceModule.java#L518-L527 We are...

I'm going to guess it was https://developer.android.com/reference/android/os/BatteryManager#BATTERY_STATUS_FULL instead of BATTERY_STATUS_CHARGING, so it was not technically charging - it was fully charged :-) the combo of "battery 100%" and "not charging"...

I'm just not sure how this line could go wrong: https://github.com/react-native-device-info/react-native-device-info/blob/78b70a07bc1248d16eb286416b78e9328cb493b4/windows/code/RNDeviceInfoCPP.h#L328C35-L328C90 We appear to be using it as documented: https://learn.microsoft.com/en-us/uwp/api/windows.system.power.powermanager.energysaverstatus?view=winrt-26100 https://learn.microsoft.com/en-us/uwp/api/windows.system.power.energysaverstatus?view=winrt-26100 Additionally, we appear to be subscribing correctly for changes...

The answer from @mspvirajpatel is the correct answer

Having react-native-tvos support as a narrowly scoped item, via support for https://github.com/react-native-tvos/react-native-tvos/ alone is useful - I'm frequently requested to maintain and/or verify support for tvOS in a few of...

@Saadnajmi great input, did not even know that I did not know that. Do you have a reference for this in repo? I see you *did* the visionos integration in...