go-alexa icon indicating copy to clipboard operation
go-alexa copied to clipboard

Add types and allow empty app ID

Open warent opened this issue 7 years ago • 12 comments

warent avatar Apr 07 '18 04:04 warent

This change makes sense and is simple enough, but you've got a couple of missing double quotes in your type JSON tags.

mikeflynn avatar Apr 07 '18 16:04 mikeflynn

I'm not sure if I should be more scared that Go never raised an error or that none of my tests picked it up

warent avatar Apr 08 '18 21:04 warent

@warent Some IDEs (I use GoLand) will call out/highlight malformed tags.

harrisonhjones avatar Apr 09 '18 15:04 harrisonhjones

The go vet tool will warn about incorrect struct tags

rking788 avatar Jul 19 '18 22:07 rking788

What's the status on this PR? This conflicts with the current master but if it's still needed, I can merge.

(Also, please don't hesitate to ping me on Twitter [@thatmikeflynn] as my GitHub notifications are impossible to keep up with and for some reason this repo is always at the bottom of the list.)

mikeflynn avatar Jul 21 '18 07:07 mikeflynn

@mikeflynn given what @rking788 mentioned how difficult would it be to add a CI check (with go vet) to PRs?

harrisonhjones avatar Jul 23 '18 01:07 harrisonhjones

That would be great! Have either of you set that up with GitHub PRs before? Any way you can point me in the right direction?

mikeflynn avatar Jul 24 '18 05:07 mikeflynn

so I'm not sure if there is a different way that I have never tried before. but the only way I can think of is to setup a travis.ci build for the repo (free for open source projects) and then run go test and go vet in the build script. A sample script can be found in the go-cmp project. Actually now that I am reading the # 86 pull request on that project it sounds like vet is running automatically with go 1.10. so it would just need to be the go test command.

rking788 avatar Jul 24 '18 14:07 rking788

I can try to setup something on my own fork of this project and then, once I get it working, I'll ping y'all.

harrisonhjones avatar Jul 24 '18 14:07 harrisonhjones

@rking788 @mikeflynn PR for adding Travis CI (with instructions!): https://github.com/mikeflynn/go-alexa/pull/45

harrisonhjones avatar Jul 24 '18 15:07 harrisonhjones

Looks like this can now be rebased and then merged?

rking788 avatar Aug 03 '18 09:08 rking788

So this got kind of lost in the shuffle. Still important? If someone can resolve the conflict we can merge.

mikeflynn avatar Oct 17 '18 05:10 mikeflynn