solvent icon indicating copy to clipboard operation
solvent copied to clipboard

Provide labels when a cycle is detected

Open milesj opened this issue 3 years ago • 3 comments
trafficstars

Right now the cycle detection isn't very helpful since it doesn't tell you where the actual problem is.

It would be nice if it included a vector of the cycle path that triggered it, for example: SolventError::CycleDetected(vec!["foo", "bar", "baz", "foo"]).

milesj avatar Dec 22 '21 04:12 milesj

I just pushed a commit that should do what you want. It passes internal tests, but I haven't used it myself (I haven't used solvent in years). Let me know if it works for you.

mikedilger avatar Dec 22 '21 19:12 mikedilger

@mikedilger Not seeing any commit :P

milesj avatar Dec 22 '21 23:12 milesj

Oops I pushed it to my private repo server. Check now.

mikedilger avatar Dec 23 '21 01:12 mikedilger