trimesh
trimesh copied to clipboard
add draco support for gltf
- add draco support for gltf
- fix #1971
Note: only export_glb with draco supported, not for gltf export yet.
The failed format check is not introduced by this merge request.
rebase done
Awesome thanks for the followup this looks a lot closer!!
- What's the maintenance plan for
pydracogltf? Would you be interested in adding it to thetrimeshgithub org? - Where's the source for the pydracogltf binary libraries? Without the source it's hard to see what's happening and we can't add it as a dependency.
- I'm happy to help setting up the CI for this, I would use this as a template: embreex/pyproject.toml
Awesome thanks for the followup this looks a lot closer!!
* What's the maintenance plan for `pydracogltf`? Would you be interested in adding it to the `trimesh` github org? * Where's the source for the [pydracogltf binary libraries](https://github.com/seed93/pydracogltf/tree/master/pydracogltf/libs)? Without the source it's hard to see what's happening and we can't add it as a dependency. * I'm happy to help setting up the CI for this, I would use this as a template: [embreex/pyproject.toml](https://github.com/mikedh/embreeX/blob/main/pyproject.toml)
I can maintain this project and I am happy to add it to trimesh github org.
The source code of this binary is here, used for blender.
Shall we merge this request?
Thanks for the followup! I think the upstream project still needs a bit of work before we can add a dependency:
- the source code for the
libsshould be added topydracogltf - the compiled artifacts in pydracogltf/libs should be removed from the repo
pyproject.tomlshould use cibuildwheel to compile the libraries from source, as in embreex/pyproject.toml- CI should release to PyPi using a token stored in the repo's secrets.