trimesh icon indicating copy to clipboard operation
trimesh copied to clipboard

add draco support for gltf

Open seed93 opened this issue 2 years ago • 6 comments

  1. add draco support for gltf
  2. fix #1971

Note: only export_glb with draco supported, not for gltf export yet.

seed93 avatar Jul 13 '23 10:07 seed93

The failed format check is not introduced by this merge request.

seed93 avatar Jul 14 '23 01:07 seed93

rebase done

seed93 avatar Jul 14 '23 01:07 seed93

Awesome thanks for the followup this looks a lot closer!!

  • What's the maintenance plan for pydracogltf? Would you be interested in adding it to the trimesh github org?
  • Where's the source for the pydracogltf binary libraries? Without the source it's hard to see what's happening and we can't add it as a dependency.
  • I'm happy to help setting up the CI for this, I would use this as a template: embreex/pyproject.toml

mikedh avatar Jul 17 '23 20:07 mikedh

Awesome thanks for the followup this looks a lot closer!!

* What's the maintenance plan for `pydracogltf`? Would you be interested in adding it to the `trimesh` github org?

* Where's the source for the [pydracogltf binary libraries](https://github.com/seed93/pydracogltf/tree/master/pydracogltf/libs)? Without the source it's hard to see what's happening and we can't add it as a dependency.

* I'm happy to help setting up the CI for this, I would use this as a template: [embreex/pyproject.toml](https://github.com/mikedh/embreeX/blob/main/pyproject.toml)

I can maintain this project and I am happy to add it to trimesh github org. The source code of this binary is here, used for blender.

seed93 avatar Jul 24 '23 06:07 seed93

Shall we merge this request?

seed93 avatar Aug 14 '23 05:08 seed93

Thanks for the followup! I think the upstream project still needs a bit of work before we can add a dependency:

  • the source code for the libs should be added to pydracogltf
  • the compiled artifacts in pydracogltf/libs should be removed from the repo
  • pyproject.toml should use cibuildwheel to compile the libraries from source, as in embreex/pyproject.toml
  • CI should release to PyPi using a token stored in the repo's secrets.

mikedh avatar Aug 16 '23 20:08 mikedh