Mike
@simonpasquier plz help me review this pr.
> Could you please add some tests too? No problem.
@slashpai plz help me review it again, i have add unit test.
> I'm wondering whether we should reuse the RemoteWriteSpec from the Prometheus CRD? > > There's a prometheus-operator submodule to this PR that is probably not needed. Submodule have removed....
> > I think thanos ruler remotewrite configuration is different from prometheus RemoteWriteSpec. > > IIUC Thanos embeds the remote write configuration from Prometheus (see https://github.com/thanos-io/thanos/blob/a6f6ce060ed4818d2c82967bfd7836588e084438/cmd/thanos/rule.go#L30). Now it' more a...
@simonpasquier I have recode it , since I don't know the relationship between remotewrite and thanos ruler versions, I just output a simple configuration according to the official documentation. Ref:https://thanos.io/tip/components/rule.md/#stateless-ruler-via-remote-write
> @mikechengwei Any chance you can find time to continue on this, based on the review? 🙏 Sorry, just saw this is not finished, I'll keep doing it.
@simonpasquier Do you have time help me review it again?
> @simonpasquier Do you have time help me review it again? hi @simonpasquier
I will follow up this feature.My idea is to create a new promtool crd resouece, using the base resource of the job api, linked the prometheusrule resource with the prometheus...