mike9421

> My best guess is that we don't apply the config to the discovery manager here: > > https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/8477a83afdfc8750d471cdb5b4af2fb227bc8423/receiver/prometheusreceiver/metrics_receiver.go#L366 > > We iterate over `cfg.ScrapeConfigs`, rather than `cfg.GetScrapeConfigs()`, which incorporates...

@swiatekm Hello, I've submitted this pull request. Could you please review it at your convenience? Thank you!

The general processing flow of "Targets" is as follows: [Discovery](https://github.com/open-telemetry/opentelemetry-operator/blob/9f152fb018e25eb407e535c5ad8b02f8fcca9f8b/cmd/otel-allocator/internal/target/discovery.go#L189) -> [NewItem](https://github.com/open-telemetry/opentelemetry-operator/blob/9f152fb018e25eb407e535c5ad8b02f8fcca9f8b/cmd/otel-allocator/internal/target/discovery.go#L207) -> [SetTargets](https://github.com/open-telemetry/opentelemetry-operator/blob/9f152fb018e25eb407e535c5ad8b02f8fcca9f8b/cmd/otel-allocator/internal/allocation/allocator.go#L76) -> [prehook](https://github.com/open-telemetry/opentelemetry-operator/blob/9f152fb018e25eb407e535c5ad8b02f8fcca9f8b/cmd/otel-allocator/internal/prehook/relabel.go#L29) -> [assign](https://github.com/open-telemetry/opentelemetry-operator/blob/9f152fb018e25eb407e535c5ad8b02f8fcca9f8b/cmd/otel-allocator/internal/allocation/allocator.go#L201) My considerations are as follows: - If deduplication is not performed before...

> Allright, I see what the problem is. What we need to defer here is not just determining the target url, but also the hash. Is that right @mike9421? >...

>I think just calculating the Hash and TargetUrl forcefully in the relabel prehook should solve it. Yes, a forced relabel operation is required. As I mentioned above, since the prehook...

The updated PR enables passing the required hash value and enhances extensibility, allowing different deduplication strategies through the use of different hash calculation methods for different `FilterStrategy`. For now, I...

@swiatekm @jaronoff97 Hi, could you please help review this PR when you have time and check if any updates are needed? This PR: - Updates the scrape target labels to...

> I _think_ this should work. Do we have any existing end to end tests that we can update or view to verify this is working as expected? Thank you...

Hi @jaronoff97 @swiatekm , could you please help review this PR when you have time? Here's a summary of the changes: - Fixed golint issues. - Removed incorrect assert statements....