BSImagePicker icon indicating copy to clipboard operation
BSImagePicker copied to clipboard

Permission handling in image picker

Open mithilesh-parmar opened this issue 4 years ago • 5 comments

  • Check for PHAuthorization status in onViewDidLoad() of AssetViewController
  • Show header for authorisation status with manage button

mithilesh-parmar avatar Jun 01 '21 17:06 mithilesh-parmar

I have yet to check this out and try it. I've only skimmed through it so far.

But this adds a feature where the image picker can show a header if it doesn't have been authorized to access a users photos?

I did see a lot of user facing strings that weren't localised though which would need to be fixed.

mikaoj avatar Dec 19 '21 12:12 mikaoj

Yes, this mimics WhatsApp-like permission handling wherein if the app has limited access to photos it will show a header wherein the user can manage permission.

I'll look into strings localisations

mithilesh-parmar avatar Dec 19 '21 12:12 mithilesh-parmar

I'll look into strings localisations

And by that I don't mean that you should translate them into 20 different languages. Just wrap them in NSLocalizedString with a good english default string and a key so anyone wanting it in another language in their app could translate it :)

mikaoj avatar Dec 19 '21 12:12 mikaoj

Cool, thanks for the heads up!

mithilesh-parmar avatar Dec 19 '21 12:12 mithilesh-parmar

Added Localized strings @mikaoj

mithilesh-parmar avatar Dec 20 '21 12:12 mithilesh-parmar