BSImagePicker icon indicating copy to clipboard operation
BSImagePicker copied to clipboard

Present (and pick) custom UImages?

Open TomMajor opened this issue 5 years ago • 4 comments

Hello, thanks for this great Swift library.

I was wondering however, it is possible to present (and pick) custom UImages, jpg etc., which are not in the Photo library, with BSImagePicker? I mean pictures like from inside the App itself or from some local directory. I could not find an example for this.

I guess we would need delegates for getting the media and the media count, like here for example: https://github.com/younatics/MediaBrowser/blob/master/MediaBrowserDemo/ViewController.swift#L81

func media(for mediaBrowser: MediaBrowser, at index: Int) -> Media { ... func numberOfMedia(in mediaBrowser: MediaBrowser) -> Int { ...

Not sure if this is already built in some way?

Thanks,

TomMajor avatar Jun 29 '20 11:06 TomMajor

Nope but it is something that I want to add. So it is possible to plug-in whichever source of images you would like.

mikaoj avatar Jun 29 '20 12:06 mikaoj

Thanks for the clarification and the quick answer. Do you have by any chance a time estimate for that? And maybe you could leave this issue open as a notification once a first version of this feature would be ready? Thanks a lot,

TomMajor avatar Jun 29 '20 14:06 TomMajor

Do you have by any chance a time estimate for that

Somewhere between now and never ;) As it is a work of love on my free time it's hard to give any promises. But seeing that Apple now has made this obsolete by offering a multiple image picker in iOS 14 I have to up my game ^^.

And maybe you could leave this issue open as a notification once a first version of this feature would be ready?

Yes I'll leave this open if there isn't an issue for it already. I know someone has asked for it before, but maybe it was over email.

If someone beats me to the punch and would like to start implementing it feel free to ping me somehow and we can discuss how it can be done as it would be a rather larger refactor.

mikaoj avatar Jun 29 '20 15:06 mikaoj

I can understand that. Being a developer in several areas for myself, I exactly know how it is when users are asking for new features which don't fit in ones priority and time constraints :crying_cat_face: Thanks for considering this as a new feature :smile:

TomMajor avatar Jun 29 '20 22:06 TomMajor