spacegray-vscode icon indicating copy to clipboard operation
spacegray-vscode copied to clipboard

PHP colors issue. Not matching when braces opened.

Open phpbits opened this issue 7 years ago • 2 comments

Trying to switch to VSCode from Sublime but the colors doesn't match. I've attached images from both editors. Thanks!

Incorrect on VSCode screen shot 2018-11-26 at 4 58 47 am

Here's how it should look. screen shot 2018-11-26 at 4 59 24 am

phpbits avatar Nov 26 '18 13:11 phpbits

will have a look at this in the coming weekend meanwhile PRs are welcome

mihai-vlc avatar Nov 26 '18 19:11 mihai-vlc

I have reviewed this and the core issue is in the language processing from VSCode.

It doesn't identify the tokens correctly when the PHP code is embedded in a style tag.

image

We will need to transfer this ticket to the vscode repository to have that issue addressed first.

mihai-vlc avatar Dec 01 '18 13:12 mihai-vlc