Miguel Grinberg

Results 482 comments of Miguel Grinberg

I still can't reproduce, but I just realized that there is a rogue `import eventlet` in the code. Assuming there is some sort of incompatibility between eventlet and asyncio, this...

As far as I can see this PR is incomplete. You are decoding messages using the provided encoder, but you are not encoding with it.

> So there are 2 commits, one In the PubSubManager for decoding and the other for encoding in the RedisManager only (i tested only this). Sorry, yes, I missed the...

There is nothing specific on the HTTP response codes. Any response status outside of the 200-399 range should trigger a disconnect. Do you have some example code I can use...

No, I haven't had time to look into this issue yet. I consider it low priority because if the server responds with a 500 it indicates a bug in the...

Okay, I need to think about how to expose these driver-specific options.

@damoit Not a good idea to allow packets of unlimited size. You should always have a maximum to prevent abuse and denial of service attacks.

You don't have to do anything besides providing the Redis connection URL, Flask-SocketIO handles all the pub/sub traffic necessary to implement emits and broadcasts.

Are the other nodes connecting to redis? I don't see why it would matter which node is the master, aren't all connections the same?

@Yael-F This is pub/sub, there is no storage, I have not considered the idea of using a cluster. I guess it is possible, but the current solution assumes all the...