mifth

Results 68 comments of mifth

Update: 1 I've moved the indicesIDs array to the Triangulator struct. https://github.com/jpcy/xatlas/pull/138/commits/45d673cc898a9ab64dd292f546679fa7454db43e 2 I've fixed zero area calculation for NGons in the AddMesh() function. https://github.com/jpcy/xatlas/pull/138/commits/0a96bd145255d3dd47c00b581d3b9933602795d0 https://github.com/jpcy/xatlas/issues/135#issuecomment-2445359944 Before: ![image](https://github.com/user-attachments/assets/a294b2b3-b646-4f2b-b37a-8ef9433f9309) After: ![image](https://github.com/user-attachments/assets/ba890786-bf31-4c95-a611-f2fcf40e7a2b)...

Update: I made final changes to the Quads/NGons support. Now all works without any artifacts! My commit: https://github.com/jpcy/xatlas/pull/138/commits/22f4d644aeff61a99af10facd579d4736c5043d4 - computeBoundaryIntersection variable is added to ChartOptions to remove artifacts (little charts)....

@jpcy could you please review my pull request. I worked hard to deliver Quads/NGons support.

Hi @castano thank you so much for your feedback. Yeah, I agree that the `computeBoundaryIntersection` might have be a bug or just designed the way when it fails in some...

Sorry, forgot to mention that to reproduce the artifacts just run this simple code: ``` xatlas::Atlas* atlas = xatlas::Create(); xatlas::AddMeshError meshError = xatlas::AddMesh(atlas, meshDecl); // Add your Mesh xatlas::ChartOptions chartOptions...

@siliconvoodoo thank you so much for your feedback. As far as I know the point of the library is to use only internal classes/structs without any dependencies. So, `std::vector` is...

@castano I checked out the computeBoundaryIntersection() function again. You are right. The function tries to remove intersected faces of a uv map. It works per mesh. But it looks like...

@castano I'm looking at the issue further. It seems the problem is not with `computeBoundaryIntersection`. `m_isInvalid` affects this issue. I've been investigating the issue further. ![image](https://github.com/user-attachments/assets/1430e4e4-ae90-4a7c-a74a-f778147d0da9)

It seems it's somewhere there: ![image](https://github.com/user-attachments/assets/6458cad9-b062-40fb-b6b1-7dcf4ae1377a)

Hi @castano @siliconvoodoo it seems I was able to fix the issue with [my latest commit](https://github.com/jpcy/xatlas/pull/138/commits/f01768abf0358d47e116755b107a89ac888f8614). A problem was in this commented code: ![image](https://github.com/user-attachments/assets/3056f7ce-4d72-4ed2-8996-f1f4d641bf05)