middleware icon indicating copy to clipboard operation
middleware copied to clipboard

feat: add team view button

Open xyfer17 opened this issue 1 year ago • 6 comments

Linked Issue(s)

#540

Acceptance Criteria fulfillment

  • [x] Add a team view button that redirects to the dora-page, showing dora-data of the team

Proposed changes (including videos or screenshots)

https://github.com/user-attachments/assets/1ba38d7f-c393-41ff-8588-7b121b682b61

Further comments

As per the issue #540, add the tiny-pill button named dora which redirect dora page, showing dora-data of the team

xyfer17 avatar Sep 26 '24 18:09 xyfer17

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 26 '24 18:09 CLAassistant

Hey @e-for-eshaan

Can you Please take a look ? Thanks :)

xyfer17 avatar Sep 26 '24 18:09 xyfer17

Functionally it's there, but visually it leaves some room to be improved. Suggestions on how we can improve this visually? @xyfer17 @e-for-eshaan

jayantbh avatar Oct 01 '24 19:10 jayantbh

@jayantbh could you please suggest any ui change make it's visual look better ?

xyfer17 avatar Oct 02 '24 07:10 xyfer17

We'll share our shot at the visual changes soon. Meanwhile, could you ensure the linter has run correctly? The CI caught some linting issues.

jayantbh avatar Oct 02 '24 07:10 jayantbh

We'll share our shot at the visual changes soon. Meanwhile, could you ensure the linter has run correctly? The CI caught some linting issues.

@jayantbh I've fixed the linting issues.

xyfer17 avatar Oct 03 '24 06:10 xyfer17

Hey @xyfer17, apologies for the silence on this. SVG:

Please use this logo/icon instead of the button in its current form.

Basically, make it so that it looks and behaves like the other icon buttons: image

And clicking on it should do the same thing that it does today.

jayantbh avatar Oct 15 '24 08:10 jayantbh

sure I'll do it and let you know after the change.

xyfer17 avatar Oct 15 '24 11:10 xyfer17