msgraph-sdk-dotnet-core icon indicating copy to clipboard operation
msgraph-sdk-dotnet-core copied to clipboard

Add test support to optionally test using a signed service library

Open MIchaelMainer opened this issue 6 years ago • 2 comments

Some M.G.D.C.Test tests take a dependency on models in M.G service library. This is fine as long as we only need to use the non-collection models like User. Otherwise, all of the collection models and request builders take a dependency on the M.G.C which is signed.

So, we need to support tests that target M.G.C in the project, and the signed+published service library and its dependency on the signed+published M.G.C.

I think we can achieve this by adding an alias to the test reference in M.G.D.C.Test project to the M.G.C project and updating the tests to use that, and then we can add a reference to the signed+published M.G.C NuGet so we can test using the service library when it requires a reference to objects defined in M.G.C.

Another option would be to bring in the service library as a submodule, and reference it via a project via an alias.

This enables:

var deltaResponse = await deltaResponseHandler.HandleResponse<EventDeltaCollectionResponse>(hrm);
EventDeltaCollectionPage deltaResponsePage = deltaResponse.Value; 
// deltaResponse.Value[0] is a property on ICollectionPage which is in the signed M.G.C 
var body = deltaResponsePage.Value[0].Body; // Can't do this now

AB#7201

MIchaelMainer avatar Oct 28 '19 22:10 MIchaelMainer

One solution to consider for test purposes: let's start copying-paste code as needed from service library.

MIchaelMainer avatar Nov 12 '19 16:11 MIchaelMainer

@MIchaelMainer @andrueastman something we still need?

ddyett avatar Jun 29 '23 01:06 ddyett